[GitHub] [ozone] chungen0126 commented on a diff in pull request #4350: HDDS-8010. Improve DN warning message when getBlock does not find the block

["chungen0126 (via GitHub)" <gi...@apache.org>]

chungen0126 commented on code in PR #4350:
URL: https://github.com/apache/ozone/pull/4350#discussion_r1125943706


##########
hadoop-hdds/container-service/src/main/java/org/apache/hadoop/ozone/container/common/helpers/ContainerUtils.java:
##########
@@ -79,16 +79,18 @@ private ContainerUtils() {
   public static ContainerCommandResponseProto logAndReturnError(
       Logger log, StorageContainerException ex,
       ContainerCommandRequestProto request) {
-    String logInfo = "Operation: {} , Trace ID: {} , Message: {} , " +
-        "Result: {} , StorageContainerException Occurred.";
+    String logInfo = "Operation: {} , Trace ID: {} , Block ID: {} , " +
+        "Message: {} , Result: {} , StorageContainerException Occurred.";
     if (ex.getResult() == CLOSED_CONTAINER_IO ||
         ex.getResult() == CONTAINER_NOT_OPEN) {
       if (log.isDebugEnabled()) {
-        log.debug(logInfo, request.getCmdType(), request.getTraceID(),
+        log.warn(logInfo, request.getCmdType(), request.getTraceID(),
+            request.getGetBlock().getBlockID(),

Review Comment:
   I think this should be still logged at DEBUG level if it is under the `isDebugEnabled()` condition.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org