[GitHub] [hudi] xuzifu666 commented on a change in pull request #4116: [HUDI-2856] Bit cask disk map delete modified

[GitBox <gi...@apache.org>]

xuzifu666 commented on a change in pull request #4116:
URL: https://github.com/apache/hudi/pull/4116#discussion_r756667186



##########
File path: hudi-common/src/main/java/org/apache/hudi/common/util/collection/BitCaskDiskMap.java
##########
@@ -281,12 +281,12 @@ public void close() {
           }
         }
       }
-      writeOnlyFile.delete();
-      this.iterators.forEach(ClosableIterator::close);
     } catch (Exception e) {
       // delete the file for any sort of exception
-      writeOnlyFile.delete();
+	  LOG.error("BitCaskDisMap close error ", e);
     } finally {
+	  this.iterators.forEach(ClosableIterator::close);

Review comment:
       okey, had fix it




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org