[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20679: [master] Add aliases for subgraph operators to be compatible with old models

[GitBox <gi...@apache.org>]

anko-intel commented on a change in pull request #20679:
URL: https://github.com/apache/incubator-mxnet/pull/20679#discussion_r731847297



##########
File path: src/operator/subgraph/dnnl/dnnl_transformer_post_quantize_property.h
##########
@@ -53,7 +53,9 @@ class SgDNNLTransformerPostQuantizeSelector : public SubgraphSelector {
 
   bool Select(const nnvm::Node& n) override {
     if ((!disable_all) && (n.op() == Op::Get("_sg_onednn_selfatt_qk") ||
-                           n.op() == Op::Get("_sg_onednn_selfatt_valatt"))) {
+                           n.op() == Op::Get("_sg_onednn_selfatt_valatt") ||

Review comment:
       one from the each pair is only needed

##########
File path: src/operator/quantization/quantize_graph_pass.cc
##########
@@ -187,7 +187,8 @@ inline QuantizeType NeedQuantize(ObjectPtr node,
         need = false;
       if (need) {
         if ((quantize_granularity == "channel-wise") &&
-            (node->op() == Op::Get("_sg_onednn_fully_connected"))) {
+            (node->op() == Op::Get("_sg_onednn_fully_connected") ||

Review comment:
       both Op::Get return the same operator - please use only one




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@mxnet.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org