You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kie.apache.org by "Rikkola (via GitHub)" <gi...@apache.org> on 2025/11/11 11:47:43 UTC
Re: [PR] [incubator-kie-issues #203] Cleanup Phreak code - Removed getActivationsManager from ReteEvaluator [incubator-kie-drools]
Rikkola commented on code in PR #6516:
URL: https://github.com/apache/incubator-kie-drools/pull/6516#discussion_r2513941876
##########
drools-core/src/main/java/org/drools/core/phreak/EagerPhreakBuilder.java:
##########
@@ -1098,8 +1098,8 @@ private static TupleImpl insertPeerLeftTuple(InternalWorkingMemory wm,
if (insert) {
TerminalNode rtn = (TerminalNode) node;
InternalAgenda agenda = wm.getAgenda();
- RuleAgendaItem agendaItem = AlphaTerminalNode.getRuleAgendaItem(wm, agenda, rtn, insert);
- PhreakRuleTerminalNode.doLeftTupleInsert(rtn, agendaItem.getRuleExecutor(), agenda, agendaItem,
+ RuleAgendaItem agendaItem = AlphaTerminalNode.getRuleAgendaItem(wm, rtn, insert);
+ PhreakRuleTerminalNode.doLeftTupleInsert(wm, rtn, agendaItem.getRuleExecutor(), agenda, agendaItem,
Review Comment:
Not related to this change, but I noticed this passes in agendaItem and rule exectutor from agendaItem. Could it just pass agendaItem and get rule executor once in?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@kie.apache.org
For additional commands, e-mail: commits-help@kie.apache.org