You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Alex Rudyy (JIRA)" <ji...@apache.org> on 2016/04/01 19:15:25 UTC
[jira] [Commented] (QPID-7159) [Java Client] Disabling user ids in
AMQP messages
[ https://issues.apache.org/jira/browse/QPID-7159?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15222005#comment-15222005 ]
Alex Rudyy commented on QPID-7159:
----------------------------------
Hi Jakub,
Your second patch adding a connection parameter "attachUserId" looks good to me. However, I would like to suggest renaming of connection parameter "attachUserId" into "populateJMSXUserID" in order to use a similar name to a connection parameter used in new JMS client for the same purpose. (See [QPIDJMS-163|https://issues.apache.org/jira/browse/QPIDJMS-163]). New JMS client parameter name is "jms.populateJMSXUserID". It has a prefix "jms." which I would suggested to omit as at the moment none of existing connection parameter in legacy JMS client has prefix.
> [Java Client] Disabling user ids in AMQP messages
> -------------------------------------------------
>
> Key: QPID-7159
> URL: https://issues.apache.org/jira/browse/QPID-7159
> Project: Qpid
> Issue Type: New Feature
> Components: Java Client
> Reporter: Jakub Scholz
> Fix For: qpid-java-6.0.2, qpid-java-6.1
>
> Attachments: QPID-7159-conn-option.patch, QPID-7159.patch
>
>
> The AMQP 0-10 JMS client seems to always attach the user-id message property to the AMQP message.
> In some cases, I don't think this is desired. For example when I send messages to my customers, I do not really want them to know which other users exist on the broker and are used to send messages.
> It would be great to have a possibility to disable the user-id when needed.
> The attached patch disables the user id in the BasicMessageProducer based on a system property qpid.attach_user_id (true/false). Does that look like a reasonable solution? If yes, I can try to add some tests.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@qpid.apache.org
For additional commands, e-mail: dev-help@qpid.apache.org