You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2022/12/01 02:03:00 UTC
[GitHub] [iotdb] liuminghui233 opened a new pull request, #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
liuminghui233 opened a new pull request, #8279:
URL: https://github.com/apache/iotdb/pull/8279
see [IOTDB-4978](https://issues.apache.org/jira/browse/IOTDB-4978).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 commented on a diff in pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
JackieTien97 commented on code in PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#discussion_r1036741499
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/IntoOperator.java:
##########
@@ -48,40 +49,70 @@ public IntoOperator(
Map<PartialPath, Map<String, TSDataType>> targetPathToDataTypeMap,
Map<String, Boolean> targetDeviceToAlignedMap,
List<Pair<String, PartialPath>> sourceTargetPathPairList,
- Map<String, InputLocation> sourceColumnToInputLocationMap) {
+ Map<String, InputLocation> sourceColumnToInputLocationMap,
+ ExecutorService intoOperationExecutor,
+ long maxStatementSize,
+ long maxReturnSize) {
super(
operatorContext,
child,
constructInsertTabletStatementGenerators(
targetPathToSourceInputLocationMap, targetPathToDataTypeMap, targetDeviceToAlignedMap),
- sourceColumnToInputLocationMap);
+ sourceColumnToInputLocationMap,
+ intoOperationExecutor,
+ maxStatementSize,
+ maxReturnSize);
this.sourceTargetPathPairList = sourceTargetPathPairList;
}
@Override
public TsBlock next() {
- TsBlock inputTsBlock = child.next();
- if (inputTsBlock != null) {
- int readIndex = 0;
- while (readIndex < inputTsBlock.getPositionCount()) {
- int lastReadIndex = readIndex;
- for (InsertTabletStatementGenerator generator : insertTabletStatementGenerators) {
- lastReadIndex =
- Math.max(lastReadIndex, generator.processTsBlock(inputTsBlock, readIndex));
- }
- readIndex = lastReadIndex;
- insertMultiTabletsInternally(true);
- }
+ if (!processWriteOperationFuture()) {
+ return null;
+ }
+
+ if (!processTsBlock(cachedTsBlock)) {
+ return null;
}
+ cachedTsBlock = null;
if (child.hasNext()) {
+ TsBlock inputTsBlock = child.next();
+ processTsBlock(inputTsBlock);
+
+ // call child.next only once
return null;
} else {
- insertMultiTabletsInternally(false);
+ if (insertMultiTabletsInternally(false)) {
+ return null;
+ }
+
+ finished = true;
return constructResultTsBlock();
}
}
+ /** Return true if write task is submitted during processing */
Review Comment:
Is this java doc right?
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/AbstractIntoOperator.java:
##########
@@ -100,27 +138,59 @@ protected void insertMultiTabletsInternally(boolean needCheck) {
}
}
if (insertTabletStatementList.isEmpty()) {
- return;
+ return null;
}
InsertMultiTabletsStatement insertMultiTabletsStatement = new InsertMultiTabletsStatement();
insertMultiTabletsStatement.setInsertTabletStatementList(insertTabletStatementList);
+ return insertMultiTabletsStatement;
+ }
+ protected void executeInsertMultiTabletsStatement(
+ InsertMultiTabletsStatement insertMultiTabletsStatement) {
if (client == null) {
client = new DataNodeInternalClient(operatorContext.getSessionInfo());
}
- TSStatus executionStatus = client.insertTablets(insertMultiTabletsStatement);
- if (executionStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
- && executionStatus.getCode() != TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) {
- String message =
- String.format(
- "Error occurred while inserting tablets in SELECT INTO: %s",
- executionStatus.getMessage());
- throw new IntoProcessException(message);
+
+ writeOperationFuture =
+ Futures.submit(
+ () -> client.insertTablets(insertMultiTabletsStatement), writeOperationExecutor);
+ }
+
+ /** Return true if the previous write task has done. */
+ protected boolean processWriteOperationFuture() {
+ if (writeOperationFuture == null) {
+ return true;
}
- for (InsertTabletStatementGenerator generator : insertTabletStatementGenerators) {
- generator.reset();
+ try {
+ if (!writeOperationFuture.isDone()) {
+ return false;
+ }
Review Comment:
if writeOperationFuture is not done, we should never call next method of into operator, so here if you just want to do a safety check, you should throw a IIlegalStateException.
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/AbstractIntoOperator.java:
##########
@@ -162,42 +232,62 @@ public OperatorContext getOperatorContext() {
return operatorContext;
}
+ private boolean writeOperationDone() {
+ if (writeOperationFuture == null) {
+ return true;
+ }
+
+ return writeOperationFuture.isDone();
+ }
+
@Override
public ListenableFuture<?> isBlocked() {
- return child.isBlocked();
+ ListenableFuture<?> childBlocked = child.isBlocked();
+ if (writeOperationDone() && childBlocked.isDone()) {
+ return NOT_BLOCKED;
+ } else if (!writeOperationDone() && childBlocked.isDone()) {
+ return writeOperationFuture;
+ } else if (writeOperationDone() && !childBlocked.isDone()) {
+ return childBlocked;
+ } else {
+ return successfulAsList(Arrays.asList(writeOperationFuture, childBlocked));
+ }
Review Comment:
```suggestion
ListenableFuture<?> childBlocked = child.isBlocked();
boolean writeDone = writeOperationDone();
if (writeDone && childBlocked.isDone()) {
return NOT_BLOCKED;
} else if (childBlocked.isDone()) {
return writeOperationFuture;
} else if (writeDone) {
return childBlocked;
} else {
return successfulAsList(Arrays.asList(writeOperationFuture, childBlocked));
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#issuecomment-1336601273
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8279)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [97 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#issuecomment-1333099550
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8279)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [8 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list) [8.9% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] liuminghui233 commented on a diff in pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
liuminghui233 commented on code in PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#discussion_r1037714252
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/AbstractIntoOperator.java:
##########
@@ -100,27 +138,59 @@ protected void insertMultiTabletsInternally(boolean needCheck) {
}
}
if (insertTabletStatementList.isEmpty()) {
- return;
+ return null;
}
InsertMultiTabletsStatement insertMultiTabletsStatement = new InsertMultiTabletsStatement();
insertMultiTabletsStatement.setInsertTabletStatementList(insertTabletStatementList);
+ return insertMultiTabletsStatement;
+ }
+ protected void executeInsertMultiTabletsStatement(
+ InsertMultiTabletsStatement insertMultiTabletsStatement) {
if (client == null) {
client = new DataNodeInternalClient(operatorContext.getSessionInfo());
}
- TSStatus executionStatus = client.insertTablets(insertMultiTabletsStatement);
- if (executionStatus.getCode() != TSStatusCode.SUCCESS_STATUS.getStatusCode()
- && executionStatus.getCode() != TSStatusCode.REDIRECTION_RECOMMEND.getStatusCode()) {
- String message =
- String.format(
- "Error occurred while inserting tablets in SELECT INTO: %s",
- executionStatus.getMessage());
- throw new IntoProcessException(message);
+
+ writeOperationFuture =
+ Futures.submit(
+ () -> client.insertTablets(insertMultiTabletsStatement), writeOperationExecutor);
+ }
+
+ /** Return true if the previous write task has done. */
+ protected boolean processWriteOperationFuture() {
+ if (writeOperationFuture == null) {
+ return true;
}
- for (InsertTabletStatementGenerator generator : insertTabletStatementGenerators) {
- generator.reset();
+ try {
+ if (!writeOperationFuture.isDone()) {
+ return false;
+ }
Review Comment:
fixed
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/AbstractIntoOperator.java:
##########
@@ -162,42 +232,62 @@ public OperatorContext getOperatorContext() {
return operatorContext;
}
+ private boolean writeOperationDone() {
+ if (writeOperationFuture == null) {
+ return true;
+ }
+
+ return writeOperationFuture.isDone();
+ }
+
@Override
public ListenableFuture<?> isBlocked() {
- return child.isBlocked();
+ ListenableFuture<?> childBlocked = child.isBlocked();
+ if (writeOperationDone() && childBlocked.isDone()) {
+ return NOT_BLOCKED;
+ } else if (!writeOperationDone() && childBlocked.isDone()) {
+ return writeOperationFuture;
+ } else if (writeOperationDone() && !childBlocked.isDone()) {
+ return childBlocked;
+ } else {
+ return successfulAsList(Arrays.asList(writeOperationFuture, childBlocked));
+ }
Review Comment:
fixed
##########
server/src/main/java/org/apache/iotdb/db/mpp/execution/operator/process/IntoOperator.java:
##########
@@ -48,40 +49,70 @@ public IntoOperator(
Map<PartialPath, Map<String, TSDataType>> targetPathToDataTypeMap,
Map<String, Boolean> targetDeviceToAlignedMap,
List<Pair<String, PartialPath>> sourceTargetPathPairList,
- Map<String, InputLocation> sourceColumnToInputLocationMap) {
+ Map<String, InputLocation> sourceColumnToInputLocationMap,
+ ExecutorService intoOperationExecutor,
+ long maxStatementSize,
+ long maxReturnSize) {
super(
operatorContext,
child,
constructInsertTabletStatementGenerators(
targetPathToSourceInputLocationMap, targetPathToDataTypeMap, targetDeviceToAlignedMap),
- sourceColumnToInputLocationMap);
+ sourceColumnToInputLocationMap,
+ intoOperationExecutor,
+ maxStatementSize,
+ maxReturnSize);
this.sourceTargetPathPairList = sourceTargetPathPairList;
}
@Override
public TsBlock next() {
- TsBlock inputTsBlock = child.next();
- if (inputTsBlock != null) {
- int readIndex = 0;
- while (readIndex < inputTsBlock.getPositionCount()) {
- int lastReadIndex = readIndex;
- for (InsertTabletStatementGenerator generator : insertTabletStatementGenerators) {
- lastReadIndex =
- Math.max(lastReadIndex, generator.processTsBlock(inputTsBlock, readIndex));
- }
- readIndex = lastReadIndex;
- insertMultiTabletsInternally(true);
- }
+ if (!processWriteOperationFuture()) {
+ return null;
+ }
+
+ if (!processTsBlock(cachedTsBlock)) {
+ return null;
}
+ cachedTsBlock = null;
if (child.hasNext()) {
+ TsBlock inputTsBlock = child.next();
+ processTsBlock(inputTsBlock);
+
+ // call child.next only once
return null;
} else {
- insertMultiTabletsInternally(false);
+ if (insertMultiTabletsInternally(false)) {
+ return null;
+ }
+
+ finished = true;
return constructResultTsBlock();
}
}
+ /** Return true if write task is submitted during processing */
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#issuecomment-1336718944
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8279)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list) [1.7% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] JackieTien97 merged pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
JackieTien97 merged PR #8279:
URL: https://github.com/apache/iotdb/pull/8279
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#issuecomment-1336611216
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8279)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [1 Bug](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [97 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list) [1.4% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#issuecomment-1334675241
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8279)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [9 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list) [2.5% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [iotdb] sonarcloud[bot] commented on pull request #8279: [To rel/1.0] [IOTDB-4978] Fix deadLock caused by blocked operation in IntoOperator
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #8279:
URL: https://github.com/apache/iotdb/pull/8279#issuecomment-1333061677
SonarCloud Quality Gate failed. [](https://sonarcloud.io/dashboard?id=apache_incubator-iotdb&pullRequest=8279)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG) [3 Bugs](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL) [6 Code Smells](https://sonarcloud.io/project/issues?id=apache_incubator-iotdb&pullRequest=8279&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list) [0.0% Coverage](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list) [9.4% Duplication](https://sonarcloud.io/component_measures?id=apache_incubator-iotdb&pullRequest=8279&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org