[GitHub] [flink-table-store] zjureel commented on a diff in pull request #305: [FLINK-28256] Move the write and prepareCommit logic of AbstractTableWrite to FileStoreWrite

[GitBox <gi...@apache.org>]

zjureel commented on code in PR #305:
URL: https://github.com/apache/flink-table-store/pull/305#discussion_r990738706


##########
flink-table-store-core/src/main/java/org/apache/flink/table/store/file/operation/FileStoreWrite.java:
##########
@@ -52,4 +56,35 @@ RecordWriter<T> createEmptyWriter(
      */
     Callable<CompactResult> createCompactWriter(
             BinaryRowData partition, int bucket, @Nullable List<DataFileMeta> compactFiles);
+
+    /**
+     * If overwrite is true, the writer will overwrite the store, otherwise it won't.
+     *
+     * @param overwrite the overwrite flag
+     */
+    void withOverwrite(boolean overwrite);
+
+    /**
+     * Write the record to the store.
+     *
+     * @param record the given record
+     * @throws Exception the thrown exception when writing the record
+     */
+    void write(SinkRecord record) throws Exception;

Review Comment:
   Thanks @JingsongLi and it looks good to me, I have updated the codes, thx



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@flink.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org