[GitHub] zhaoyongjie commented on a change in pull request #5687: [bugfix] Encode unicode error message response

[GitBox <gi...@apache.org>]

zhaoyongjie commented on a change in pull request #5687: [bugfix] Encode unicode error message response
URL: https://github.com/apache/incubator-superset/pull/5687#discussion_r211819642
 
 

 ##########
 File path: superset/views/base.py
 ##########
 @@ -45,7 +45,7 @@ def get_error_msg():
 
 def json_error_response(msg=None, status=500, stacktrace=None, payload=None, link=None):
     if not payload:
-        payload = {'error': str(msg)}
+        payload = {'error': msg.encode('utf-8')}
 
 Review comment:
   @mistercrunch  Thank you for reminding. updated commit

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org