Re: [PR] HIVE-27126: queue level resource stats for YARN RM. [hive]

["abstractdog (via GitHub)" <gi...@apache.org>]

abstractdog commented on code in PR #6501:
URL: https://github.com/apache/hive/pull/6501#discussion_r3702365903


##########
common/src/test/org/apache/hadoop/hive/common/log/TestInPlaceUpdate.java:
##########
@@ -0,0 +1,182 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.hadoop.hive.common.log;
+
+import org.junit.Test;
+
+import java.io.ByteArrayOutputStream;
+import java.io.PrintStream;
+import java.util.Arrays;
+import java.util.Collections;
+import java.util.List;
+
+import static org.junit.Assert.assertEquals;
+import static org.junit.Assert.assertTrue;
+
+/**
+ * Unit tests for InPlaceUpdate — focusing on the queue-metrics separator
+ * behaviour added as part of HIVE-27126.
+ *
+ * We capture stdout via a ByteArrayOutputStream and inspect the rendered output.
+ */public class TestInPlaceUpdate {

Review Comment:
   TestInPlaceUpdate disappeared in the meantime from the PR
   if it's not needed anymore, feel free to resolve this comment, otherwise I'm happy to see that test case



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org