[GitHub] [phoenix-omid] stoty commented on a diff in pull request #108: OMID-224 Switch default logging backend to log4j2

[GitBox <gi...@apache.org>]

stoty commented on code in PR #108:
URL: https://github.com/apache/phoenix-omid/pull/108#discussion_r939812812


##########
hbase-commit-table/pom.xml:
##########
@@ -112,13 +117,32 @@
             <artifactId>curator-test</artifactId>
             <scope>test</scope>
         </dependency>
+
+
+        <!-- log4j2 test dependencies -->
+
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>
+            <artifactId>log4j-api</artifactId>
+            <scope>test</scope>
+        </dependency>
+        <dependency>
+            <groupId>org.apache.logging.log4j</groupId>
+            <artifactId>log4j-core</artifactId>
+            <scope>test</scope>
+        </dependency>
         <dependency>
-            <groupId>org.apache.zookeeper</groupId>
-            <artifactId>zookeeper</artifactId>

Review Comment:
   It was never needed in that module.
   
   TBH dependencies are stil a mess in Omid.
   We SHOULD depend on ZK in _timestamp-storage_ , and _tso-server_ but  the dependency was never defined there.
   We also define a ZK version properrty in the top pom that we don't use now, and have never used properly.
   
   At some point, we should clean up the dependencies and add maven-dependency-plugin check.
   
   Now we're effectively using whatever ZK version the HBase version we're building with is pulling in, which should be fine.
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@phoenix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org