[GitHub] [netbeans] matthiasblaesing commented on pull request #2557: fix for indexing JSF composite components

[GitBox <gi...@apache.org>]

matthiasblaesing commented on pull request #2557:
URL: https://github.com/apache/netbeans/pull/2557#issuecomment-733941824


   @fcorneli thank you for your work. This issue troubles me @work also. It is nice to see this getting fixed. I rebuild a nightly and try to test this in the next few days. In the meantime, I have to things I noticed right now:
   
   - please ensure an issue exists, that covers your changes
   - make sure the title of the PR and the commit summary start with the issue number in the format "[NETBEANS-????] <Summary>"
   - either you should have an ICLA on file or I have to ask you whether you understand and agree, that you donate the change to the ASF. At this point in time this means, that the code is covered by the ALv2, but the ASF is free to relicense in the future und any license it chooses. With an ICLA this is part of the agreement, if you plan to contribute more (this would be great!), an ICLA is preferred, if not, please comment with the acknowledgement into the corresponding issues.
   
   If you have questions, feel free to ask here or (preferred on the dev@netbeans.apache.org  mailinglist (http://netbeans.apache.org/community/mailing-lists.html)


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists