You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by pk...@apache.org on 2022/10/30 15:03:50 UTC

[incubator-nuttx] 09/22: Fix usbdev/usbmsc_desc.c:316:7: error: variable 'length' set but not used [-Werror,-Wunused-but-set-variable]

This is an automated email from the ASF dual-hosted git repository.

pkarashchenko pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/incubator-nuttx.git

commit 929882862b6682862b6eea3990c71aba2151faeb
Author: Xiang Xiao <xi...@xiaomi.com>
AuthorDate: Wed Oct 26 11:08:43 2022 +0800

    Fix usbdev/usbmsc_desc.c:316:7: error: variable 'length' set but not used [-Werror,-Wunused-but-set-variable]
    
    Signed-off-by: Xiang Xiao <xi...@xiaomi.com>
---
 drivers/usbdev/usbmsc_desc.c | 9 ++-------
 1 file changed, 2 insertions(+), 7 deletions(-)

diff --git a/drivers/usbdev/usbmsc_desc.c b/drivers/usbdev/usbmsc_desc.c
index 320b5d9df0..fe435c6f47 100644
--- a/drivers/usbdev/usbmsc_desc.c
+++ b/drivers/usbdev/usbmsc_desc.c
@@ -313,7 +313,6 @@ int16_t usbmsc_mkcfgdesc(uint8_t *buf,
                         FAR struct usbdev_devinfo_s *devinfo)
 #endif
 {
-  int length = 0;
   bool hispeed = false;
 
 #ifdef CONFIG_USBDEV_DUALSPEED
@@ -359,8 +358,7 @@ int16_t usbmsc_mkcfgdesc(uint8_t *buf,
                         USBMSC_REMOTEWAKEUP;
       dest->mxpower     = (CONFIG_USBDEV_MAXPOWER + 1) / 2; /* Max power (mA/2) */
 
-      buf    += sizeof(struct usb_cfgdesc_s);
-      length += sizeof(struct usb_cfgdesc_s);
+      buf += sizeof(struct usb_cfgdesc_s);
     }
 #endif
 
@@ -381,8 +379,7 @@ int16_t usbmsc_mkcfgdesc(uint8_t *buf,
       dest->protocol = USBMSC_PROTO_BULKONLY;                    /* Interface protocol */
       dest->iif      = devinfo->strbase + USBMSC_INTERFACESTRID; /* iInterface */
 
-      buf    += sizeof(struct usb_ifdesc_s);
-      length += sizeof(struct usb_ifdesc_s);
+      buf += sizeof(struct usb_ifdesc_s);
     }
 
   /* Make the two endpoint configurations */
@@ -395,7 +392,6 @@ int16_t usbmsc_mkcfgdesc(uint8_t *buf,
                                    devinfo, hispeed);
 
       buf += len;
-      length += len;
     }
 
   /* Bulk OUT endpoint descriptor */
@@ -406,7 +402,6 @@ int16_t usbmsc_mkcfgdesc(uint8_t *buf,
                                    hispeed);
 
       buf += len;
-      length += len;
     }
 
   return SIZEOF_USBMSC_CFGDESC;