Re: svn commit: r788077 - /tomcat/tc6.0.x/trunk/STATUS.txt

[Mladen Turk <mt...@apache.org>]

kkolinko@apache.org wrote:
> Author: kkolinko
>  
>  * When throwing Non-serializable exception, mark which argument was
> @@ -163,6 +163,13 @@
>    6.0.x version of the patch:
>    http://people.apache.org/~mturk/tomcat/setAttribute.iae.patch
>    +1: mturk
> +  -1: kkolinko: (
> +      good in general, but
> +      1) please use native2ascii for LocalStrings_fr.properties
> +      s/ e / \u00nn /

I made the patch before all that native2ascii stuff changed.
However I updated the patch.

> +      2) o.a.c.session.ha.session.LocalString*.properties files also have this string.
> +      Should it be removed from there, or updated there also?

This has nothing to do with the patch.
It's a separate issue that requires cleanup of o.a.c.session.ha which has
lots of unused entries probably due to copy/paste.
At least the standardSession.setAttribute.iae is never used inside
the o.a.c.session.ha package.

Regards
-- 
^(TM)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org