You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@openwhisk.apache.org by GitBox <gi...@apache.org> on 2020/02/25 11:30:11 UTC
[GitHub] [openwhisk] codecov-io commented on issue #4838: Remove usages of
Unit as a value.
codecov-io commented on issue #4838: Remove usages of Unit as a value.
URL: https://github.com/apache/openwhisk/pull/4838#issuecomment-590821687
# [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4838?src=pr&el=h1) Report
> Merging [#4838](https://codecov.io/gh/apache/openwhisk/pull/4838?src=pr&el=desc) into [master](https://codecov.io/gh/apache/openwhisk/commit/a3d9491faab68196395c8653e08db1422dad57da?src=pr&el=desc) will **increase** coverage by `39.55%`.
> The diff coverage is `60%`.
[](https://codecov.io/gh/apache/openwhisk/pull/4838?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #4838 +/- ##
===========================================
+ Coverage 36.52% 76.07% +39.55%
===========================================
Files 197 197
Lines 9016 9016
Branches 361 372 +11
===========================================
+ Hits 3293 6859 +3566
+ Misses 5723 2157 -3566
```
| [Impacted Files](https://codecov.io/gh/apache/openwhisk/pull/4838?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...e/openwhisk/core/mesos/MesosContainerFactory.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvbWVzb3MvTWVzb3NDb250YWluZXJGYWN0b3J5LnNjYWxh) | `60.71% <0%> (+60.71%)` | :arrow_up: |
| [...cala/org/apache/openwhisk/core/yarn/YARNTask.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUveWFybi9ZQVJOVGFzay5zY2FsYQ==) | `70% <0%> (+70%)` | :arrow_up: |
| [...nwhisk/core/database/RemoteCacheInvalidation.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvUmVtb3RlQ2FjaGVJbnZhbGlkYXRpb24uc2NhbGE=) | `80% <100%> (ø)` | :arrow_up: |
| [...g/apache/openwhisk/core/database/UserCommand.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-dG9vbHMvYWRtaW4vc3JjL21haW4vc2NhbGEvb3JnL2FwYWNoZS9vcGVud2hpc2svY29yZS9kYXRhYmFzZS9Vc2VyQ29tbWFuZC5zY2FsYQ==) | `97.82% <100%> (+97.82%)` | :arrow_up: |
| [...whisk/core/database/cosmosdb/CosmosDBSupport.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZGF0YWJhc2UvY29zbW9zZGIvQ29zbW9zREJTdXBwb3J0LnNjYWxh) | `0% <0%> (ø)` | :arrow_up: |
| [.../org/apache/openwhisk/core/entity/EntityPath.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvZW50aXR5L0VudGl0eVBhdGguc2NhbGE=) | `100% <0%> (+1.88%)` | :arrow_up: |
| [.../org/apache/openwhisk/http/PoolingRestClient.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2h0dHAvUG9vbGluZ1Jlc3RDbGllbnQuc2NhbGE=) | `91.17% <0%> (+2.94%)` | :arrow_up: |
| [...la/org/apache/openwhisk/common/TransactionId.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29tbW9uL3NjYWxhL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvbW1vbi9UcmFuc2FjdGlvbklkLnNjYWxh) | `93.65% <0%> (+3.17%)` | :arrow_up: |
| [...sk/core/containerpool/docker/DockerContainer.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ29udGFpbmVyLnNjYWxh) | `96.47% <0%> (+3.52%)` | :arrow_up: |
| [...tainerpool/docker/DockerClientWithFileAccess.scala](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree#diff-Y29yZS9pbnZva2VyL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvb3BlbndoaXNrL2NvcmUvY29udGFpbmVycG9vbC9kb2NrZXIvRG9ja2VyQ2xpZW50V2l0aEZpbGVBY2Nlc3Muc2NhbGE=) | `96% <0%> (+4%)` | :arrow_up: |
| ... and [122 more](https://codecov.io/gh/apache/openwhisk/pull/4838/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/openwhisk/pull/4838?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/openwhisk/pull/4838?src=pr&el=footer). Last update [a3d9491...62b4c96](https://codecov.io/gh/apache/openwhisk/pull/4838?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services