You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Arun Patidar (JIRA)" <ji...@apache.org> on 2010/04/15 12:33:07 UTC
[jira] Created: (OFBIZ-3703) updatePartyContactMech service creates
new record while contactMechId is unchange.
updatePartyContactMech service creates new record while contactMechId is unchange.
----------------------------------------------------------------------------------
Key: OFBIZ-3703
URL: https://issues.apache.org/jira/browse/OFBIZ-3703
Project: OFBiz
Issue Type: Bug
Components: party, specialpurpose/ecommerce
Affects Versions: SVN trunk
Reporter: Arun Patidar
Priority: Minor
Fix For: SVN trunk
updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3703) updatePartyContactMech service
creates new record while contactMechId is unchange.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878922#action_12878922 ]
Jacques Le Roux commented on OFBIZ-3703:
----------------------------------------
I backported r954583+954733 (in 954733 I put back some line I faultly removed yesterday evening) in R10.04 at r954737+954782
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch, OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-3703) updatePartyContactMech service creates
new record while contactMechId is unchange.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-3703:
--------------------------------
Attachment: OFBIZ-3703.patch
Changed patch as per Scott's comment. Thanks Scott.
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch, OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3703) updatePartyContactMech service
creates new record while contactMechId is unchange.
Posted by "Pranay Pandey (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857270#action_12857270 ]
Pranay Pandey commented on OFBIZ-3703:
--------------------------------------
Thanks for the contribution Arun, I reviewed the patch and looks good to me. We should not always create a new PartyContactMech if its not changed at all.
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3703) updatePartyContactMech service
creates new record while contactMechId is unchange.
Posted by "Jacques Le Roux (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12878691#action_12878691 ]
Jacques Le Roux commented on OFBIZ-3703:
----------------------------------------
There was a bug in this: it did not take into account the specific case of extension. I have fixed it at r954583
This bug was in updatePartyContactMech. When you wanted to update only the extension of a phone number it did not get stored. I said "that seems to have been introduced" because it's working in stable demo without changes, so I guess it's related to the change in this issue
I also remove a useless couple of lines at the beginning of the updatePartyContactMech service.
Finally I must say that I find very weird to have extension in PartyContactMech entity. It would be certainly more logical to have in TelecomNumber. Is it really used for anything else than phone number extension?
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch, OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-3703) updatePartyContactMech service creates
new record while contactMechId is unchange.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya closed OFBIZ-3703.
--------------------------------------
Resolution: Fixed
Thanks Arun for the contribution - Committed at r934389.
--
Ashish Vijaywargiya
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch, OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Commented: (OFBIZ-3703) updatePartyContactMech service
creates new record while contactMechId is unchange.
Posted by "Scott Gray (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12857269#action_12857269 ]
Scott Gray commented on OFBIZ-3703:
-----------------------------------
Hi Arun, why not just move the store and create down to the existing if block directly below your new one? (it has the same condition)
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Updated: (OFBIZ-3703) updatePartyContactMech service creates
new record while contactMechId is unchange.
Posted by "Arun Patidar (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Arun Patidar updated OFBIZ-3703:
--------------------------------
Attachment: OFBIZ-3703.patch
Here is a patch for fix this issue.
Thanks & Regards
---
Arun Patidar
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] Assigned: (OFBIZ-3703) updatePartyContactMech service
creates new record while contactMechId is unchange.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-3703?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-3703:
------------------------------------------
Assignee: Ashish Vijaywargiya
> updatePartyContactMech service creates new record while contactMechId is unchange.
> ----------------------------------------------------------------------------------
>
> Key: OFBIZ-3703
> URL: https://issues.apache.org/jira/browse/OFBIZ-3703
> Project: OFBiz
> Issue Type: Bug
> Components: party, specialpurpose/ecommerce
> Affects Versions: SVN trunk
> Reporter: Arun Patidar
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-3703.patch, OFBIZ-3703.patch
>
>
> updatePartyContactMech service should not expire old record and create new record when contactMechId is unchange.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira