You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "dongjoon-hyun (via GitHub)" <gi...@apache.org> on 2024/09/18 23:54:42 UTC
[PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
dongjoon-hyun opened a new pull request, #69:
URL: https://github.com/apache/spark-docker/pull/69
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If there is design documentation, please add the link.
2. If there is a discussion in the mailing list, please add the link.
-->
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you fix a bug, you can clarify why it is a bug.
-->
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-docker/pull/69#issuecomment-2359701390
Thank you, @Yikun .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-docker/pull/69#issuecomment-2359662317
For the record, while preparing `4.0.0-preview2` release, I'm making this repo up-to-date by re-implementing the Apache Spark patches like the following. The following three are published to https://hub.docker.com/r/apache/spark/ .
- #66
- #67
- #68
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-docker/pull/69#issuecomment-2360030593
For the record, Java 21 images are published successfully.
- https://github.com/apache/spark-docker/actions/runs/10934045296
- https://hub.docker.com/layers/apache/spark/4.0.0-preview1-java21/images/sha256-5e0bb8becda30b59fcbd712dfac99aad22d50683c0df986a77f3db7c9d78e5e6?context=explore
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-docker/pull/69#issuecomment-2359660177
Thank you, @HyukjinKwon .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on code in PR #69:
URL: https://github.com/apache/spark-docker/pull/69#discussion_r1765906008
##########
versions.json:
##########
@@ -1,5 +1,34 @@
{
"versions": [
+ {
+ "path": "4.0.0-preview1/scala2.13-java21-python3-ubuntu",
+ "tags": [
+ "4.0.0-preview1-scala2.13-java21-python3-ubuntu",
+ "4.0.0-preview1-java21-python3",
+ "4.0.0-java21",
+ "python3-java21"
Review Comment:
I'm okay with this, anther choice maybe better to add this after 4.0.0 published?
##########
versions.json:
##########
@@ -1,5 +1,34 @@
{
"versions": [
+ {
+ "path": "4.0.0-preview1/scala2.13-java21-python3-ubuntu",
+ "tags": [
+ "4.0.0-preview1-scala2.13-java21-python3-ubuntu",
+ "4.0.0-preview1-java21-python3",
+ "4.0.0-java21",
Review Comment:
4.0.0-preview1-java21
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun closed pull request #69: [SPARK-49703] Publish Java 21 Docker image for preview1
URL: https://github.com/apache/spark-docker/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #69:
URL: https://github.com/apache/spark-docker/pull/69#discussion_r1765902901
##########
README.md:
##########
@@ -35,7 +35,7 @@ You can see [3.4.0 PR](https://github.com/apache/spark-docker/pull/33) as refere
### Step 2. Publish apache/spark Images.
-Click [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
+Click [Publish (Java 21 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml), [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
Review Comment:
```suggestion
Click [Publish (Java 21 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java21.yaml), [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
```
```suggestion
Click [Publish (Java 21 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml), [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "Yikun (via GitHub)" <gi...@apache.org>.
Yikun commented on code in PR #69:
URL: https://github.com/apache/spark-docker/pull/69#discussion_r1765906008
##########
versions.json:
##########
@@ -1,5 +1,34 @@
{
"versions": [
+ {
+ "path": "4.0.0-preview1/scala2.13-java21-python3-ubuntu",
+ "tags": [
+ "4.0.0-preview1-scala2.13-java21-python3-ubuntu",
+ "4.0.0-preview1-java21-python3",
+ "4.0.0-java21",
+ "python3-java21"
Review Comment:
I'm okay with this, anther choice maybe better to add this after 4.0.0 release?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #69:
URL: https://github.com/apache/spark-docker/pull/69#discussion_r1765902901
##########
README.md:
##########
@@ -35,7 +35,7 @@ You can see [3.4.0 PR](https://github.com/apache/spark-docker/pull/33) as refere
### Step 2. Publish apache/spark Images.
-Click [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
+Click [Publish (Java 21 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml), [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
Review Comment:
```suggestion
Click [Publish (Java 21 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java21.yaml), [Publish (Java 17 only)](https://github.com/apache/spark-docker/actions/workflows/publish-java17.yaml) (such as 4.x) or [Publish](https://github.com/apache/spark-docker/actions/workflows/publish.yml) (such as 3.x) to publish images.
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-docker/pull/69#issuecomment-2359663269
Thank you, @viirya .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #69:
URL: https://github.com/apache/spark-docker/pull/69#discussion_r1765914121
##########
versions.json:
##########
@@ -1,5 +1,34 @@
{
"versions": [
+ {
+ "path": "4.0.0-preview1/scala2.13-java21-python3-ubuntu",
+ "tags": [
+ "4.0.0-preview1-scala2.13-java21-python3-ubuntu",
+ "4.0.0-preview1-java21-python3",
+ "4.0.0-java21",
+ "python3-java21"
Review Comment:
Let me remove this. :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #69:
URL: https://github.com/apache/spark-docker/pull/69#discussion_r1765913952
##########
versions.json:
##########
@@ -1,5 +1,34 @@
{
"versions": [
+ {
+ "path": "4.0.0-preview1/scala2.13-java21-python3-ubuntu",
+ "tags": [
+ "4.0.0-preview1-scala2.13-java21-python3-ubuntu",
+ "4.0.0-preview1-java21-python3",
+ "4.0.0-java21",
Review Comment:
Oh, right. Thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-49703] Publish Java 21 Docker image for preview1 [spark-docker]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on PR #69:
URL: https://github.com/apache/spark-docker/pull/69#issuecomment-2359910110
Thank you, @HyukjinKwon , @viirya , @Yikun .
Merged to master.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org