You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org> on 2017/06/03 19:47:10 UTC

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0 

Thomas Tauber-Marshall has uploaded a new change for review.

  http://gerrit.cloudera.org:8080/7072

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................

IMPALA-5426: Update Hive schema script to 1.1.0

A recent update to Hive changed its schema, which is causing
the metastore not to come up as we've hard coded the Hive schema
script version in bin/create-test-configuration.sh to an old
version.

This patch updates the version to the latest. In the long run,
we should switch to using Hive's schema tool, which can do this
for us automatically (IMPALA-5430).

Testing:
- Ran an exhaustive private Jenkins build that passed.

Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
---
M bin/create-test-configuration.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/7072/1
-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


Patch Set 1: Code-Review+1

Thank you for fixing this. Is the hive schema file available on all systems this may run on? Can you add a comment to the commit message explaining what dependency contains it?

-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Lars Volker (Code Review)" <ge...@cloudera.org>.
Lars Volker has posted comments on this change.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


Patch Set 2: Code-Review+2

MJ, I think no reload will be necessary but after https://gerrit.cloudera.org/7076 goes in you'll have to update the schema using the schematool.

-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


Patch Set 2: Verified+1

-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Thomas Tauber-Marshall has posted comments on this change.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


Patch Set 1:

> Thank you for fixing this. Is the hive schema file available on all
 > systems this may run on? Can you add a comment to the commit
 > message explaining what dependency contains it?
Yes, it should always be available through Hive in the toolchain just as the previous version of the script was.

 > What will this mean for developers who already have the old version
 > loaded? Is a HMS reload necessary?

This patch by itself won't require a reload by default, as the default version of Hive we run against doesn't include the schema change, but a reload will be necessary after the follow up patch that bumps the toolchain to 5.13

-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Thomas Tauber-Marshall (Code Review)" <ge...@cloudera.org>.
Hello Lars Volker,

I'd like you to reexamine a change.  Please visit

    http://gerrit.cloudera.org:8080/7072

to look at the new patch set (#2).

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................

IMPALA-5426: Update Hive schema script to 1.1.0

A recent update to Hive changed its schema, which is causing
the metastore not to come up when run against the latest version
of Hive as we've hard coded the Hive schema script version in
bin/create-test-configuration.sh to an old version.

This patch updates the version to the latest. The schema script
is included in Hive in the toolchain and the new version will
already be present.

By itself, this patch does not actually change the Hive schema
by default as the version we usually build against doesn't have
the change. A following patch will update impala-config.sh to pull
in the latest version of Hive.

In the long run, we should switch to using Hive's schema tool,
which can do this for us automatically (IMPALA-5430).

Testing:
- Ran an exhaustive private Jenkins build that passed.

Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
---
M bin/create-test-configuration.sh
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/72/7072/2
-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


Patch Set 2:

Build started: http://jenkins.impala.io:8080/job/gerrit-verify-dryrun/676/

-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


Patch Set 1:

What will this mean for developers who already have the old version loaded? Is a HMS reload necessary?

-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 1
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


IMPALA-5426: Update Hive schema script to 1.1.0

A recent update to Hive changed its schema, which is causing
the metastore not to come up when run against the latest version
of Hive as we've hard coded the Hive schema script version in
bin/create-test-configuration.sh to an old version.

This patch updates the version to the latest. The schema script
is included in Hive in the toolchain and the new version will
already be present.

By itself, this patch does not actually change the Hive schema
by default as the version we usually build against doesn't have
the change. A following patch will update impala-config.sh to pull
in the latest version of Hive.

In the long run, we should switch to using Hive's schema tool,
which can do this for us automatically (IMPALA-5430).

Testing:
- Ran an exhaustive private Jenkins build that passed.

Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Reviewed-on: http://gerrit.cloudera.org:8080/7072
Reviewed-by: Lars Volker <lv...@cloudera.com>
Tested-by: Impala Public Jenkins
---
M bin/create-test-configuration.sh
1 file changed, 1 insertion(+), 1 deletion(-)

Approvals:
  Impala Public Jenkins: Verified
  Lars Volker: Looks good to me, approved



-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 3
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>

[Impala-ASF-CR] IMPALA-5426: Update Hive schema script to 1.1.0

Posted by "Matthew Jacobs (Code Review)" <ge...@cloudera.org>.
Matthew Jacobs has posted comments on this change.

Change subject: IMPALA-5426: Update Hive schema script to 1.1.0
......................................................................


Patch Set 2:

Ok, WFM, I just wanted to make sure we don't break development environments. Thanks

-- 
To view, visit http://gerrit.cloudera.org:8080/7072
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9ea3269c1f95f76d8c02b76a5dea3ca3aa324b70
Gerrit-PatchSet: 2
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-Owner: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-Reviewer: Lars Volker <lv...@cloudera.com>
Gerrit-Reviewer: Matthew Jacobs <mj...@cloudera.com>
Gerrit-Reviewer: Thomas Tauber-Marshall <tm...@cloudera.com>
Gerrit-HasComments: No