You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by cloud-fan <gi...@git.apache.org> on 2017/11/14 10:00:02 UTC

[GitHub] spark pull request #18641: [SPARK-21413][SQL] Fix 64KB JVM bytecode limit pr...

Github user cloud-fan commented on a diff in the pull request:

    https://github.com/apache/spark/pull/18641#discussion_r150785676
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala ---
    @@ -2158,4 +2158,21 @@ class DataFrameSuite extends QueryTest with SharedSQLContext {
         val mean = result.select("DecimalCol").where($"summary" === "mean")
         assert(mean.collect().toSet === Set(Row("0.0345678900000000000000000000000000000")))
       }
    +
    +  testQuietly("SPARK-21413: Multiple projections with CASE WHEN fails") {
    +    val schema = StructType(StructField("a", IntegerType) :: Nil)
    +    val df = spark.createDataFrame(sparkContext.parallelize(Seq(Row(1))), schema)
    +    val df1 =
    +      df.withColumn("a", when($"a" === 0, null).otherwise($"a"))
    --- End diff --
    
    maybe use a loop here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org