Review Request 45107: NO-JIRA: Fixed compile and link errors

[Alan Conway <ac...@redhat.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45107/
-----------------------------------------------------------

Review request for qpid, Ganesh Murthy, Kenneth Giusti, and Ted Ross.


Repository: qpid-dispatch


Description
-------

Several "variable not initiatialized" warnings.
The offer one was definitely a bug but I'm not 100% sure of my fix..
Added missing extern declarations on const char* constants.

Several tests are failing after this fix, not sure if the fix is the
problem or they were already failing.


Diffs
-----

  include/qpid/dispatch/amqp.h 2793c6de2006855ae3121b3c0f6ad55a7569cc7c 
  src/router_core/transfer.c 47b499b16c5b04286c7cdc5534a3704b06f24ed7 
  src/router_node.c bf093df28d59548087f3c2fd95844fdeb920313f 

Diff: https://reviews.apache.org/r/45107/diff/


Testing
-------

ctest -VV shows several errors I am not sure if they were caused by my fix or were pre-existing


======================================================================
FAIL: test_create_connector_waypoint (system_tests_management.ManagementTest)
Test creating waypoint, connector and fixedAddress
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aconway/dispatch/tests/system_tests_management.py", line 300, in test_create_connector_waypoint
    self.assertEqual(6, len(re.findall(r'MESSAGE.*to=.*/foo', f.read())))
AssertionError: 6 != 0

======================================================================
FAIL: test_dummy (system_tests_management.ManagementTest)
Test all operations on the dummy test entity
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aconway/dispatch/tests/system_tests_management.py", line 323, in test_dummy
    self.assertRaises(NotImplementedStatus, entity.delete)
AssertionError: NotImplementedStatus not raised

======================================================================
FAIL: test_get_operations (system_tests_management.ManagementTest)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aconway/dispatch/tests/system_tests_management.py", line 461, in test_get_operations
    self.assertEqual(["READ"], result[LINK])
AssertionError: Lists differ: ['READ'] != [u'UPDATE', u'READ']

First differing element 0:
READ
UPDATE

Second list contains 1 additional elements.
First extra element 1:
READ

- ['READ']
+ [u'UPDATE', u'READ']

======================================================================
FAIL: test_query_attributes (system_tests_management.ManagementTest)
Query with attributes only
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aconway/dispatch/tests/system_tests_management.py", line 151, in test_query_attributes
    self.assertTrue(r in response.results)
AssertionError: False is not true

======================================================================
FAIL: test_query_type (system_tests_management.ManagementTest)
Query with type only
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aconway/dispatch/tests/system_tests_management.py", line 132, in test_query_type
    set(['l0', 'l1', 'l2']) <= set(r['name'] for r in response.get_entities()))
AssertionError: False is not true

======================================================================
FAIL: test_query_type_attributes (system_tests_management.ManagementTest)
Query with type and attribute names
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/home/aconway/dispatch/tests/system_tests_management.py", line 141, in test_query_type_attributes
    self.assertTrue(r in response.results)
AssertionError: False is not true

----------------------------------------------------------------------
Ran 20 tests in 34.795s


Thanks,

Alan Conway