[jira] [Commented] (HIVE-11550) ACID queries pollute HiveConf

["Alan Gates (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-11550?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15267627#comment-15267627 ] 

Alan Gates commented on HIVE-11550:
-----------------------------------

Are the changes in Optimizer.java and AbstractCorrelationProcCtx.java related or did they get into the patch by accident?  If they are there intentionally it's not clear how they are related, so some comments would be helpful.

> ACID queries pollute HiveConf
> -----------------------------
>
>                 Key: HIVE-11550
>                 URL: https://issues.apache.org/jira/browse/HIVE-11550
>             Project: Hive
>          Issue Type: Bug
>          Components: Transactions
>    Affects Versions: 1.0.0
>            Reporter: Eugene Koifman
>            Assignee: Eugene Koifman
>         Attachments: HIVE-11550.patch
>
>
> HiveConf is a SessionState level object.  Some ACID related logic makes changes to it (which are meant to be per query) but become per SessionState.
> See SemanticAnalyzer.checkAcidConstraints()
> Also note       HiveConf.setVar(conf, HiveConf.ConfVars.DYNAMICPARTITIONINGMODE, "nonstrict");
> in UpdateDeleteSemancitAnalzyer
> [~alangates], do you know of other cases or ideas on how to deal with this differently?
> _SortedDynPartitionOptimizer.process()_ is the place to have the logic to do _conf.setBoolVar(ConfVars.HIVEOPTSORTDYNAMICPARTITION, false);_ on per query basis



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)