r23113 changes (was: Re: svn commit: r23110 - in branches/perl-bindings-improvements: . subversion/bindings/swig/perl/native/t)

[Nik Clayton <ni...@ngo.org.uk>]

That reminds me.  r23113

     http://jc.ngo.org.uk/svnweb/subversion/revision/?rev=23113

is what most of my next commits to the perl-bindings-improvements branch are 
going to look like.  Any comments, or thoughts?  I'd rather get those now, 
before I do much of the work, than at the end of the process :-)

N

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: r23113 changes

[Daniel Rall <dl...@collab.net>]

On Tue, 23 Jan 2007, Nik Clayton wrote:

> David Glasser wrote:
...
> >(And we should make sure that when a version with this in it is
> >released, we don't forget to include the new dep in CHANGES, and
> >perhaps even proactively notify some of the packagers who provide the
> >bindings.)
> 
> Is there a standard place to put notes like this (i.e., notes to ourselves 
> before a release is cut)?  Should I just raise a ticket with the details in 
> so that it's not lost?

An issue would be a good way to go (AFAIK, we don't have such file on
trunk, only branch-specific README.branch or TODO files).

Re: r23113 changes

[Nik Clayton <ni...@ngo.org.uk>]

David Glasser wrote:
> Perl is Perl and writing good Perl does generally mean using CPAN
> modules.  And I see you have added the dependency to swig/INSTALL.
> Perhaps you should mention a specific version number that you have
> tested as working, and make sure (at least manually, if not in the
> test suite) that both the pure-Perl and XS implementation of
> Param::Validate work?

That seems reasonable, and should be possible to automate.

> (And we should make sure that when a version with this in it is
> released, we don't forget to include the new dep in CHANGES, and
> perhaps even proactively notify some of the packagers who provide the
> bindings.)

Is there a standard place to put notes like this (i.e., notes to ourselves 
before a release is cut)?  Should I just raise a ticket with the details in 
so that it's not lost?

N

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: r23113 changes

[David Glasser <gl...@mit.edu>]

On 1/21/07, Nik Clayton <ni...@ngo.org.uk> wrote:
> OK.  Can I make sure there's a consensus on this before I expend much more
> effort please.  I've bought this up a couple of times before.  I first
> mentioned the idea on 24th Nov, then posted patches that implemented it on
> 30th Nov and 12th Dec, and again mentioned the external dependency
> requirement on 17th Jan, before I committed.
>
> Each time, the only comment was that we needed to document the requirement
> clearly.

Yeah, I've been pretty busy with school and work lately and haven't
had time to monitor the list as well as I'd like to.

Perl is Perl and writing good Perl does generally mean using CPAN
modules.  And I see you have added the dependency to swig/INSTALL.
Perhaps you should mention a specific version number that you have
tested as working, and make sure (at least manually, if not in the
test suite) that both the pure-Perl and XS implementation of
Param::Validate work?

(And we should make sure that when a version with this in it is
released, we don't forget to include the new dep in CHANGES, and
perhaps even proactively notify some of the packagers who provide the
bindings.)

--dave

-- 
David Glasser | glasser@mit.edu | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: r23113 changes

[Nik Clayton <ni...@ngo.org.uk>]

David Glasser wrote:
> Hmm.  So the Perl bindings will now require Param::Validate?  They
> don't currently (on trunk) require any non-standard modules, right?

Yes.  And yes.

> This is probably OK, though it'll need to be made clear in INSTALL,
> and we should make sure that repackagers are aware of the new deps.

OK.  Can I make sure there's a consensus on this before I expend much more 
effort please.  I've bought this up a couple of times before.  I first 
mentioned the idea on 24th Nov, then posted patches that implemented it on 
30th Nov and 12th Dec, and again mentioned the external dependency 
requirement on 17th Jan, before I committed.

Each time, the only comment was that we needed to document the requirement 
clearly.

As long as everyone's fine with that, great.  But if there's any nervousness 
about introducing this external dependency I'd like to discuss it now.

Cheers,

N

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org

Re: r23113 changes (was: Re: svn commit: r23110 - in branches/perl-bindings-improvements: . subversion/bindings/swig/perl/native/t)

[David Glasser <gl...@mit.edu>]

On 1/20/07, Nik Clayton <ni...@ngo.org.uk> wrote:
> That reminds me.  r23113
>
>      http://jc.ngo.org.uk/svnweb/subversion/revision/?rev=23113
>
> is what most of my next commits to the perl-bindings-improvements branch are
> going to look like.  Any comments, or thoughts?  I'd rather get those now,
> before I do much of the work, than at the end of the process :-)

Hmm.  So the Perl bindings will now require Param::Validate?  They
don't currently (on trunk) require any non-standard modules, right?

This is probably OK, though it'll need to be made clear in INSTALL,
and we should make sure that repackagers are aware of the new deps.

--dave

-- 
David Glasser | glasser@mit.edu | http://www.davidglasser.net/

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org