You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@wicket.apache.org by martin-g <gi...@git.apache.org> on 2018/10/12 07:00:52 UTC

[GitHub] wicket pull request #295: WICKET-6586 Broken JavaScript due to fix charsetNa...

GitHub user martin-g opened a pull request:

    https://github.com/apache/wicket/pull/295

    WICKET-6586 Broken JavaScript due to fix charsetName in JavaScriptPac…

    …kageResource
    
    Introduce PackageResource#getProcessingEncoding() that could be overridden by the application to use a custom encoding to read a resource from the class path.
    Move the compressing logic from Css/JavaScript-PackageResource to PackageResource class to DRY it.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/apache/wicket WICKET-6586-introduce-processing-encoding

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/wicket/pull/295.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #295
    
----
commit 072b2fc7fd521ec07e40fc5af16b75db47694b33
Author: Martin Tzvetanov Grigorov <mg...@...>
Date:   2018-10-12T06:58:04Z

    WICKET-6586 Broken JavaScript due to fix charsetName in JavaScriptPackageResource
    
    Introduce PackageResource#getProcessingEncoding() that could be overridden by the application to use a custom encoding to read a resource from the class path.
    Move the compressing logic from Css/JavaScript-PackageResource to PackageResource class to DRY it.

----


---

[GitHub] wicket pull request #295: WICKET-6586 Broken JavaScript due to fix charsetNa...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/wicket/pull/295


---

[GitHub] wicket issue #295: WICKET-6586 Broken JavaScript due to fix charsetName in J...

Posted by svenmeier <gi...@git.apache.org>.

Github user svenmeier commented on the issue:

    https://github.com/apache/wicket/pull/295
  
    +1


---