[GitHub] [arrow-datafusion] alamb commented on a change in pull request #922: WIP Optimize hash_aggregate when there are no null group keys

[GitBox <gi...@apache.org>]

alamb commented on a change in pull request #922:
URL: https://github.com/apache/arrow-datafusion/pull/922#discussion_r693880303



##########
File path: datafusion/src/scalar.rs
##########
@@ -1095,6 +1105,78 @@ impl ScalarValue {
         }
     }
 
+
+    /// an unsafe version of `eq_array` optimised for the situation
+    /// where we know in advance that the array has no nulls
+    #[inline]
+    pub fn eq_array_no_nulls(&self, array: &ArrayRef, index:usize) -> bool {
+        if let DataType::Dictionary(key_type, _) = array.data_type() {
+            return self.eq_array_dictionary(array, index, key_type);

Review comment:
       I think this should perhaps also be `self.eq_array_dictionary_no_nulls` and have a corresponding dictionary special case. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org