You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "Aias00 (via GitHub)" <gi...@apache.org> on 2026/08/25 22:58:26 UTC
[PR] Fix alert rule form value contract [rocketmq-dashboard]
Aias00 opened a new pull request, #2606:
URL: https://github.com/apache/rocketmq-dashboard/pull/2606
## Summary
- keep localized metric and duration labels while submitting Prometheus-compatible identifiers and durations
- preserve threshold units for normalized metrics
- normalize legacy display values when editing older rules
- add regression coverage for payload normalization
Fixes #2603
## Tests
- `cd web && npm test -- --run src/pages/ops/__tests__/alerts.test.ts src/pages/ops/__tests__/AlertsPage.test.tsx`
- `cd web && npm run build`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix alert rule form value contract [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 commented on PR #2606:
URL: https://github.com/apache/rocketmq-dashboard/pull/2606#issuecomment-5502805882
Superseded by #2965, which consolidates this change with the related Studio fixes on the current `rocketmq-studio` baseline. The replacement PR is Ready and currently CLEAN/MERGEABLE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix alert rule form value contract [rocketmq-dashboard]
Posted by "Aias00 (via GitHub)" <gi...@apache.org>.
Aias00 closed pull request #2606: Fix alert rule form value contract
URL: https://github.com/apache/rocketmq-dashboard/pull/2606
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix alert rule form value contract [rocketmq-dashboard]
Posted by "RockteMQ-AI (via GitHub)" <gi...@apache.org>.
RockteMQ-AI commented on PR #2606:
URL: https://github.com/apache/rocketmq-dashboard/pull/2606#issuecomment-5439987487
⚠️ **Merge conflict detected**
This PR has conflicts with the base branch and cannot be merged. Please rebase or merge the base branch into your branch and resolve the conflicts:
```bash
git fetch origin
git checkout fix/studio-alert-rule-form-contract-2603
git rebase origin/main
# resolve conflicts, then:
git push --force-with-lease
```
This is a one-time reminder. Feel free to @mention me for a re-review after conflicts are resolved.
---
*Automated notification by "github-manager-bot"*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org