You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2019/10/02 19:42:41 UTC
[kudu-CR] [mini cluster] fix adding NTP flags for tservers
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14350
Change subject: [mini_cluster] fix adding NTP flags for tservers
......................................................................
[mini_cluster] fix adding NTP flags for tservers
This patch fixes adding NTP-related flags for tablet servers. Prior
to this change, the NTP-related flags were added _after_ custom flags
specified by ExternalMiniClusterOptions::extra_tserver_flags, but it's
expected the latter are the last ones. A few tests manipulate the flags
after first start of a tablet server, expecting some particular order:
those would fail if not keeping the expected flags order.
Change-Id: Ia6c45f4a50c3850a2bdeae88720f78737dc1b270
---
M src/kudu/mini-cluster/external_mini_cluster.cc
1 file changed, 4 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/50/14350/1
--
To view, visit http://gerrit.cloudera.org:8080/14350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia6c45f4a50c3850a2bdeae88720f78737dc1b270
Gerrit-Change-Number: 14350
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [mini cluster] fix adding NTP flags for tservers
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/14350 )
Change subject: [mini_cluster] fix adding NTP flags for tservers
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia6c45f4a50c3850a2bdeae88720f78737dc1b270
Gerrit-Change-Number: 14350
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Wed, 02 Oct 2019 19:49:45 +0000
Gerrit-HasComments: No
[kudu-CR] [mini cluster] fix adding NTP flags for tservers
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14350 )
Change subject: [mini_cluster] fix adding NTP flags for tservers
......................................................................
[mini_cluster] fix adding NTP flags for tservers
This patch fixes adding NTP-related flags for tablet servers. Prior
to this change, the NTP-related flags were added _after_ custom flags
specified by ExternalMiniClusterOptions::extra_tserver_flags, but it's
expected the latter are the last ones. A few tests manipulate the flags
after first start of a tablet server, expecting some particular order:
those would fail if not keeping the expected flags order.
Change-Id: Ia6c45f4a50c3850a2bdeae88720f78737dc1b270
Reviewed-on: http://gerrit.cloudera.org:8080/14350
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Kudu Jenkins
---
M src/kudu/mini-cluster/external_mini_cluster.cc
1 file changed, 4 insertions(+), 1 deletion(-)
Approvals:
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/14350
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia6c45f4a50c3850a2bdeae88720f78737dc1b270
Gerrit-Change-Number: 14350
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)