You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "gortiz (via GitHub)" <gi...@apache.org> on 2023/09/25 13:01:15 UTC
[GitHub] [pinot] gortiz commented on a diff in pull request #11673: Change json_format to return java null when java null is received
gortiz commented on code in PR #11673:
URL: https://github.com/apache/pinot/pull/11673#discussion_r1335857827
##########
pinot-core/src/test/java/org/apache/pinot/core/data/function/JsonFunctionsTest.java:
##########
@@ -137,4 +137,19 @@ public Object[][] jsonFunctionsDataProvider()
});
return inputs.toArray(new Object[0][]);
}
+
+ @Test(description = "jsonFormat(Java null) should return Java null")
+ public void jsonFormatWithJavaNullReturnsJavaNull() {
+ GenericRow row = new GenericRow();
+ row.putValue("jsonMap", null);
+ testFunction("json_format(jsonMap)", Lists.newArrayList("jsonMap"), row, null);
Review Comment:
This test fails if executed in master. Instead of Java null, what was returned was the String "null"
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org