You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by oleg03 <gi...@git.apache.org> on 2015/05/14 06:27:34 UTC
[GitHub] storm pull request: [STORM-710] bin/storm command list out all the...
GitHub user oleg03 opened a pull request:
https://github.com/apache/storm/pull/553
[STORM-710] bin/storm command list out all the classes in the output for a command
Added -v flag for all bin/storm commands.
Long commands' outputs are removed.
Using -v flag prints traditional long output.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/oleg03/storm test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/553.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #553
----
commit 963b002cbc57be7292c72bb657a9b5d60f788a04
Author: oleg03 <ol...@gmail.com>
Date: 2015-05-14T04:22:44Z
[STORM-710]
Added -v flag for all bin/storm commands.
Long commands' outputs are removed.
Using -v flag prints traditional long output.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-710] bin/storm command list out all the...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/553#issuecomment-113996523
@oleg03 can you send us a new patch with @revans2 feedback . Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-710] bin/storm command list out all the...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/553#issuecomment-106580985
I like the concept, but by having storm.py pull the -v out of the command line, it now makes it impossible for any command to use -v any other way. This is not a big deal for the typical storm commands, but for storm jar it is backwards incompatible. This is especially a problem for something that for some reason had a -v with an argument. I would much rather use an environment variable, or a rather log parameter like '--storm-system-verbose' which is not likely to have any collision.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-710] bin/storm command list out all the...
Posted by knusbaum <gi...@git.apache.org>.
Github user knusbaum commented on the pull request:
https://github.com/apache/storm/pull/553#issuecomment-193489974
Closing this. Feel free to reopen with updates.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-710] bin/storm command list out all the...
Posted by revans2 <gi...@git.apache.org>.
Github user revans2 commented on the pull request:
https://github.com/apache/storm/pull/553#issuecomment-155916895
@oleg03 I don't really like the idea of adding in a -v option that restricts all other commands, including storm jar from supporting it. I would much rather have a long parameter that is unlikely to collide with something someone else is already using, or us a config or environment variable to trigger it instead.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: [STORM-710] bin/storm command list out all the...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/storm/pull/553
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---