[GitHub] [hbase] Joseph295 commented on a change in pull request #1783: HBASE-24436 The store file open and close thread pool should be share…

[GitBox <gi...@apache.org>]

Joseph295 commented on a change in pull request #1783:
URL: https://github.com/apache/hbase/pull/1783#discussion_r430876977



##########
File path: hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
##########
@@ -695,6 +695,7 @@ void sawNoSuchFamily() {
   private RegionCoprocessorHost coprocessorHost;
 
   private TableDescriptor htableDescriptor = null;
+  private ThreadPoolExecutor storeFileOpenAndCloseThreadPool;

Review comment:
       > If I understand the jira correctly, what you are trying to solve is below case.
   > One region with say 2 stores. Store1 having much more files than other. Say the config for the #threads in open pool is 10. Now it will create 2 pools for each store with 5 threads each. The Store2 will get finished soon. But store1 will take much longer. So if it was a shared pool of 10 threads the overall time for opening both stores would have been lesser. my understanding correct?
   
   Yes, just that case.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org