You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@datafusion.apache.org by "adriangb (via GitHub)" <gi...@apache.org> on 2025/10/24 14:28:50 UTC
[PR] Add entry to upgrade guide for #18231 [datafusion]
adriangb opened a new pull request, #18269:
URL: https://github.com/apache/datafusion/pull/18269
Generated by Claude, but looks good to me :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add entry to upgrade guide for #18231 [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #18269:
URL: https://github.com/apache/datafusion/pull/18269#discussion_r2460783215
##########
docs/source/library-user-guide/upgrading.md:
##########
@@ -116,6 +116,39 @@ Users may need to update their paths to account for these changes.
See [issue #17713] for more details.
+### `FileScanConfigBuilder` now uses `TableSchema` internally
+
+The `FileScanConfigBuilder` has been refactored to use `TableSchema` directly instead of managing `file_schema` and `table_partition_cols` separately. This simplifies the builder's internal state management and makes the API more consistent.
+
+**Impact:** This change is mostly internal and should not affect most users. The public API of `FileScanConfigBuilder` remains the same - you still use `with_table_partition_cols()` to set partition columns.
+
+However, if you were directly constructing `FileScanConfigBuilder` from a `FileScanConfig` (via the `From` trait) or accessing its internal fields, you may need to update your code.
+
+**Before:**
+
+```rust
+# /* comment to avoid running
+let builder = FileScanConfigBuilder {
+ file_schema: my_schema,
+ table_partition_cols: partition_cols,
+ ...
+};
+# */
+```
Review Comment:
```suggestion
```rust,ignore
let builder = FileScanConfigBuilder {
file_schema: my_schema,
table_partition_cols: partition_cols,
...
};
```
```
Same for below, see:
https://github.com/apache/datafusion/blob/22c4214fe1ca3953932f3f12ccd5b68dbfbefdf3/docs/source/library-user-guide/upgrading.md?plain=1#L206-L208
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add entry to upgrade guide for #18231 [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on code in PR #18269:
URL: https://github.com/apache/datafusion/pull/18269#discussion_r2460863187
##########
docs/source/library-user-guide/upgrading.md:
##########
@@ -116,6 +116,35 @@ Users may need to update their paths to account for these changes.
See [issue #17713] for more details.
+### `FileScanConfigBuilder` now uses `TableSchema` internally
+
+The `FileScanConfigBuilder` has been refactored to use `TableSchema` directly instead of managing `file_schema` and `table_partition_cols` separately. This simplifies the builder's internal state management and makes the API more consistent.
+
+**Impact:** This change is mostly internal and should not affect most users. The public API of `FileScanConfigBuilder` remains the same - you still use `with_table_partition_cols()` to set partition columns.
+
+However, if you were directly constructing `FileScanConfigBuilder` from a `FileScanConfig` (via the `From` trait) or accessing its internal fields, you may need to update your code.
+
+**Before:**
+
+```rust,ignore
+let builder = FileScanConfigBuilder {
+ file_schema: my_schema,
+ table_partition_cols: partition_cols,
+ ...
+};
+```
Review Comment:
Yup you're totally right, I thought they were hence making this PR. Seems like no breaking change :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add entry to upgrade guide for #18231 [datafusion]
Posted by "Jefffrey (via GitHub)" <gi...@apache.org>.
Jefffrey commented on code in PR #18269:
URL: https://github.com/apache/datafusion/pull/18269#discussion_r2460814901
##########
docs/source/library-user-guide/upgrading.md:
##########
@@ -116,6 +116,35 @@ Users may need to update their paths to account for these changes.
See [issue #17713] for more details.
+### `FileScanConfigBuilder` now uses `TableSchema` internally
+
+The `FileScanConfigBuilder` has been refactored to use `TableSchema` directly instead of managing `file_schema` and `table_partition_cols` separately. This simplifies the builder's internal state management and makes the API more consistent.
+
+**Impact:** This change is mostly internal and should not affect most users. The public API of `FileScanConfigBuilder` remains the same - you still use `with_table_partition_cols()` to set partition columns.
+
+However, if you were directly constructing `FileScanConfigBuilder` from a `FileScanConfig` (via the `From` trait) or accessing its internal fields, you may need to update your code.
+
+**Before:**
+
+```rust,ignore
+let builder = FileScanConfigBuilder {
+ file_schema: my_schema,
+ table_partition_cols: partition_cols,
+ ...
+};
+```
Review Comment:
I think this is a hallucination? Fields in `FileScanConfigBuilder` aren't public so users wouldn't be able to construct it manually
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add entry to upgrade guide for #18231 [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb commented on code in PR #18269:
URL: https://github.com/apache/datafusion/pull/18269#discussion_r2460808567
##########
docs/source/library-user-guide/upgrading.md:
##########
@@ -116,6 +116,39 @@ Users may need to update their paths to account for these changes.
See [issue #17713] for more details.
+### `FileScanConfigBuilder` now uses `TableSchema` internally
+
+The `FileScanConfigBuilder` has been refactored to use `TableSchema` directly instead of managing `file_schema` and `table_partition_cols` separately. This simplifies the builder's internal state management and makes the API more consistent.
+
+**Impact:** This change is mostly internal and should not affect most users. The public API of `FileScanConfigBuilder` remains the same - you still use `with_table_partition_cols()` to set partition columns.
+
+However, if you were directly constructing `FileScanConfigBuilder` from a `FileScanConfig` (via the `From` trait) or accessing its internal fields, you may need to update your code.
+
+**Before:**
+
+```rust
+# /* comment to avoid running
+let builder = FileScanConfigBuilder {
+ file_schema: my_schema,
+ table_partition_cols: partition_cols,
+ ...
+};
+# */
+```
Review Comment:
done, thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org
Re: [PR] Add entry to upgrade guide for #18231 [datafusion]
Posted by "adriangb (via GitHub)" <gi...@apache.org>.
adriangb closed pull request #18269: Add entry to upgrade guide for #18231
URL: https://github.com/apache/datafusion/pull/18269
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscribe@datafusion.apache.org
For additional commands, e-mail: github-help@datafusion.apache.org