[GitHub] [arrow-datafusion] Jimexist commented on pull request #622: fix 621, where unnamed window functions shall be differentiated by partition and order by clause

[GitBox <gi...@apache.org>]

Jimexist commented on pull request #622:
URL: https://github.com/apache/arrow-datafusion/pull/622#issuecomment-868956435


   > should we update physical column name as well for better readability in the query output? https://github.com/apache/arrow-datafusion/blob/master/datafusion/src/physical_plan/planner.rs#L137-L139
   
   i think this is more of the strategy on how we name unnamed columns in the schema. for window functions without an alias, it'll be created with a unique name, given the function type, arg name, partition by clause, order by clause, and window frames. any of these are equivalent then the columns can be thought of the same and thus deduplicated in the projection phase, otherwise they will be planned separately.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org