You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/11/06 13:04:49 UTC
[GitHub] [zookeeper] maoling opened a new pull request #1527: ZOOKEEPER-3986: [branch-3.5]ConcurrentModificationException in PrepRequestProcessor.checkACL when iterating and add authInfo List concurrently
maoling opened a new pull request #1527:
URL: https://github.com/apache/zookeeper/pull/1527
- This issue only exists in the `branch-3.5` and was fixed by [ZOOKEEPER-1525](https://issues.apache.org/jira/browse/ZOOKEEPER-1525) indirectly. I recheck that both [branch-3.6](https://github.com/apache/zookeeper/blob/branch-3.6/zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java#L63) and [master branch](https://github.com/apache/zookeeper/blob/master/zookeeper-server/src/main/java/org/apache/zookeeper/server/ServerCnxn.java#L63) did not have this issue.
- For the unit case, it's a minor bug and unworthy to write a too complicated test suit to assert the specific
`ConcurrentModificationException`. From the client's view, it will get a `MarshallingErrorException`.
The propagation mechanism is:
```
FinalRequestProcessor#OpCode.getChildren2 --->
PrepRequestProcessor.checkACL(ConcurrentModificationException) --->
err = Code.MARSHALLINGERROR ---> reply to the client
```
- [A code snippet](https://issues.apache.org/jira/browse/ZOOKEEPER-3986?focusedCommentId=17224223&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17224223) which can reproduce this issue.
- more details in the [ZOOKEEPER-3986](https://issues.apache.org/jira/browse/ZOOKEEPER-3986)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [zookeeper] maoling closed pull request #1527: ZOOKEEPER-3986: [branch-3.5]ConcurrentModificationException in PrepRequestProcessor.checkACL when iterating and add authInfo List concurrently
Posted by GitBox <gi...@apache.org>.
maoling closed pull request #1527:
URL: https://github.com/apache/zookeeper/pull/1527
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org