You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/06/09 14:41:42 UTC
[GitHub] [hudi] KnightChess opened a new pull request, #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
KnightChess opened a new pull request, #5820:
URL: https://github.com/apache/hudi/pull/5820
## What is the purpose of the pull request
improve the memory use in ExpressionPayload, cache the same schema
## Brief change log
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1151250215
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* f37b563744ec6736c7baac2cb43ed7936d4f4465 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 merged pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
danny0405 merged PR #5820:
URL: https://github.com/apache/hudi/pull/5820
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1157310829
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
}, {
"hash" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326",
"triggerID" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"triggerType" : "PUSH"
}, {
"hash" : "bacc544806657a9eef955df5e8c270bdbea6866e",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9332",
"triggerID" : "bacc544806657a9eef955df5e8c270bdbea6866e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* fa73fb90b97fb000e1d95030f5afd0ae6be8da54 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326)
* bacc544806657a9eef955df5e8c270bdbea6866e Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9332)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1151216747
improve beforeļ¼
<img width="889" alt="image" src="https://user-images.githubusercontent.com/20125927/172874844-ade62a3f-0965-4ed8-99db-e629df290068.png">
after:
<img width="991" alt="image" src="https://user-images.githubusercontent.com/20125927/172875111-83784258-880c-4d20-a696-71d2f10775ba.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1155265918
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* f37b563744ec6736c7baac2cb43ed7936d4f4465 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190)
* a80cb0644c67049814dbe77416587fc7189599e5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1157168036
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
}, {
"hash" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* a80cb0644c67049814dbe77416587fc7189599e5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293)
* fa73fb90b97fb000e1d95030f5afd0ae6be8da54 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1155351037
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* f37b563744ec6736c7baac2cb43ed7936d4f4465 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190)
* a80cb0644c67049814dbe77416587fc7189599e5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1157204615
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
}, {
"hash" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326",
"triggerID" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* fa73fb90b97fb000e1d95030f5afd0ae6be8da54 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1151237760
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1151244349
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* f37b563744ec6736c7baac2cb43ed7936d4f4465 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] KnightChess commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
KnightChess commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1157473865
@danny0405 thanks for review :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1155570275
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* a80cb0644c67049814dbe77416587fc7189599e5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1157175288
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
}, {
"hash" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326",
"triggerID" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* a80cb0644c67049814dbe77416587fc7189599e5 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293)
* fa73fb90b97fb000e1d95030f5afd0ae6be8da54 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1151378986
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* f37b563744ec6736c7baac2cb43ed7936d4f4465 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a diff in pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
danny0405 commented on code in PR #5820:
URL: https://github.com/apache/hudi/pull/5820#discussion_r898644837
##########
hudi-spark-datasource/hudi-spark/src/main/scala/org/apache/spark/sql/hudi/command/payload/ExpressionPayload.scala:
##########
@@ -214,11 +214,7 @@ class ExpressionPayload(record: GenericRecord,
* Init the table schema.
*/
private def initWriteSchemaIfNeed(properties: Properties): Unit = {
- if (writeSchema == null) {
- ValidationUtils.checkArgument(properties.containsKey(HoodieWriteConfig.WRITE_SCHEMA.key),
- s"Missing ${HoodieWriteConfig.WRITE_SCHEMA.key}")
- writeSchema = new Schema.Parser().parse(properties.getProperty(HoodieWriteConfig.WRITE_SCHEMA.key))
- }
+ writeSchema = setWriteSchema(properties)
}
Review Comment:
Seems you want to make the schema object as singleton for different payload instance, then the null check may still makes sense here. I mean the decision `if (writeSchema == null)` should be kept.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1157297733
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
}, {
"hash" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326",
"triggerID" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"triggerType" : "PUSH"
}, {
"hash" : "bacc544806657a9eef955df5e8c270bdbea6866e",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "bacc544806657a9eef955df5e8c270bdbea6866e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* fa73fb90b97fb000e1d95030f5afd0ae6be8da54 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326)
* bacc544806657a9eef955df5e8c270bdbea6866e UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #5820: [HUDI-4214] improve repeat init write schema in ExpressionPayload
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #5820:
URL: https://github.com/apache/hudi/pull/5820#issuecomment-1157462938
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ee8e3bca9d7d02c818cc4c11c7fd7a3192600063",
"triggerType" : "PUSH"
}, {
"hash" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9190",
"triggerID" : "f37b563744ec6736c7baac2cb43ed7936d4f4465",
"triggerType" : "PUSH"
}, {
"hash" : "a80cb0644c67049814dbe77416587fc7189599e5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9293",
"triggerID" : "a80cb0644c67049814dbe77416587fc7189599e5",
"triggerType" : "PUSH"
}, {
"hash" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9326",
"triggerID" : "fa73fb90b97fb000e1d95030f5afd0ae6be8da54",
"triggerType" : "PUSH"
}, {
"hash" : "bacc544806657a9eef955df5e8c270bdbea6866e",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9332",
"triggerID" : "bacc544806657a9eef955df5e8c270bdbea6866e",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ee8e3bca9d7d02c818cc4c11c7fd7a3192600063 UNKNOWN
* bacc544806657a9eef955df5e8c270bdbea6866e Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=9332)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org