You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by bu...@apache.org on 2012/12/21 09:23:20 UTC
[Bug 54336] New: connection may not close in JDBCRealm when some
exception happen
https://issues.apache.org/bugzilla/show_bug.cgi?id=54336
Bug ID: 54336
Summary: connection may not close in JDBCRealm when some
exception happen
Product: Tomcat 7
Version: 7.0.34
Hardware: PC
Status: NEW
Severity: normal
Priority: P2
Component: Catalina
Assignee: dev@tomcat.apache.org
Reporter: cndoublehero@gmail.com
Classification: Unclassified
connection may not close in JDBCRealm when some exception happen. Take public
synchronized Principal authenticate(String username, String credentials)
method for a example, if some exception (not SQLException) is been throw by the
code , without finally code, the connection will never close. I think this is a
issue.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54336] connection may not close in JDBCRealm when some
exception happen
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54336
Mark Thomas <ma...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |INVALID
--- Comment #2 from Mark Thomas <ma...@apache.org> ---
+1 to what Violeta said.
Bug reports based purely on code analysis need to include a clear explanation
of what could go wrong and why. The problem also needs to stand some chance of
actually happening.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54336] connection may not close in JDBCRealm when some
exception happen
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54336
--- Comment #3 from cndoublehero <cn...@gmail.com> ---
ok. Simple and clear. I accpet that.
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org
[Bug 54336] connection may not close in JDBCRealm when some
exception happen
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=54336
Violeta Georgieva <vi...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
OS| |All
--- Comment #1 from Violeta Georgieva <vi...@apache.org> ---
Hi,
According to the JDBCRealm implementation, the db connection is kept opened and
reused whenever it is needed.
It is like a simple connection pool with just one connection.
The connection is closed only when there is an SQLException in order to reopen
a new connection and ensure its clean state.
I think that the connection should not be closed each time as the overall
performance will be severely affected.
Regards
Violeta Georgieva
--
You are receiving this mail because:
You are the assignee for the bug.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org