[jira] [Resolved] (OFBIZ-5750) Convert Party entites CRUD service from simple to entity-auto

["Gil Portenseigne (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/OFBIZ-5750?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Gil Portenseigne resolved OFBIZ-5750.
-------------------------------------
       Resolution: Fixed
    Fix Version/s: Upcoming Branch

Fixed in 
Trunk r1714976
14.12 r1714977

I did review all createPartyRole service call in *.*, and replace some of the occurence with ensurePartyRole, one in SubscriptionServices.java that could cause issue, and others to ease the readability.

The ones i left were mainly used in party creation...


> Convert Party entites CRUD service from simple to entity-auto
> -------------------------------------------------------------
>
>                 Key: OFBIZ-5750
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-5750
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: party
>    Affects Versions: Trunk
>            Reporter: Nicolas Malin
>            Assignee: Jacques Le Roux
>            Priority: Trivial
>              Labels: crud, entity-auto
>             Fix For: 14.12.01, Upcoming Branch
>
>         Attachments: OFBIZ-5750.patch, OFBIZ-5750.patch
>
>
> I converted CRUD service to entity-auto for :
>   PartyRole
>   PostalAddressBoundary
>   PartyClassification
>   PartyClassificationGroup
>   PartyAttribute
>   Vendor
>   PartyCarrierAccount
> Only entity with their services present on PartyServices.xml
> I change the PartyRole  attributes service like that
> {code}
> -        <attribute name="partyId" type="String" mode="IN" optional="true"/>
> -        <attribute name="roleTypeId" type="String" mode="IN" optional="false"/>
> +        <auto-attributes include="pk" mode="IN" optional="false"/>
> {code}
> The currently simple method haven't a specific resolution if the partyId isn't pass, so the service failed with database constraint error.
> I run manual test from Party Profile screen with success (except for PostalAddressBoundary that haven't standard screen, so call by runService) and I run ./ant clean-all load-demo run-tests without error



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)