You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by GitBox <gi...@apache.org> on 2020/10/02 14:14:22 UTC
[GitHub] [maven-javadoc-plugin] Syquel opened a new pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
Syquel opened a new pull request #63:
URL: https://github.com/apache/maven-javadoc-plugin/pull/63
Replaces the usage of the full commandline by only its arguments to generate the stale javadoc detection key.
This approach allows to handle file-arguments appropriately in case of double-quoting by resolving them to their actual arguments.
- [x] I hereby declare this contribution to be licenced under the [Apache License Version 2.0, January 2004](http://www.apache.org/licenses/LICENSE-2.0)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] Syquel edited a comment on pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
Posted by GitBox <gi...@apache.org>.
Syquel edited a comment on pull request #63:
URL: https://github.com/apache/maven-javadoc-plugin/pull/63#issuecomment-785090906
@slachiewicz I documented that mostly in [MJAVADOC-664](https://issues.apache.org/jira/browse/MJAVADOC-664).
Do you need anything else?
Writing a unit test for this fix would require some time, which I am currently not able to invest, because there is no unit test for the feature itself yet.
//EDIT
For reference: #33 introduced this feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] michaelboyles commented on pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
Posted by GitBox <gi...@apache.org>.
michaelboyles commented on pull request #63:
URL: https://github.com/apache/maven-javadoc-plugin/pull/63#issuecomment-702943734
Not a committer, but I think this unlikely to be accepted without a test
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] Syquel commented on pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
Posted by GitBox <gi...@apache.org>.
Syquel commented on pull request #63:
URL: https://github.com/apache/maven-javadoc-plugin/pull/63#issuecomment-785090906
@slachiewicz I documented that mostly in [MJAVADOC-664](https://issues.apache.org/jira/browse/MJAVADOC-664).
Do you need anything else?
Writing a unit test for this fix would require some time, which I am currently not able to invest, because there is no unit test for the feature itself yet.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slachiewicz commented on pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
Posted by GitBox <gi...@apache.org>.
slachiewicz commented on pull request #63:
URL: https://github.com/apache/maven-javadoc-plugin/pull/63#issuecomment-785057254
How I can test that functionality?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven-javadoc-plugin] slachiewicz merged pull request #63: [MJAVADOC-664] - Fix stale javadoc data detection on Windows.
Posted by GitBox <gi...@apache.org>.
slachiewicz merged pull request #63:
URL: https://github.com/apache/maven-javadoc-plugin/pull/63
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org