[GitHub] [maven-doxia] elharo commented on pull request #160: [DOXIA-698] Make Sink implement AutoCloseable

["elharo (via GitHub)" <gi...@apache.org>]

elharo commented on PR #160:
URL: https://github.com/apache/maven-doxia/pull/160#issuecomment-1487018107

   That behavior doesn't change. If a Sink implementation closes the stream/writer when the sink is closed, then it will still be closed when stream/writer is autoclosed. If the Sink implementation doesn't close the  stream/writer when the sink is closed, then it won't be closed now. Nothing in this PR changes what happens when a Sink's close method is invoked. It just enables try-with-resources to be used to implicitly invoke the close method instead of explicitly calling it. This makes for slightly simpler code and makes resource leaks where the sink isn't closed at all less likely. 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org