You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by lc...@apache.org on 2017/04/25 16:38:57 UTC
[1/2] beam git commit: [BEAM-1877] Use Iterables.isEmpty in
GroupIntoBatches
Repository: beam
Updated Branches:
refs/heads/master 000378d6a -> 6bca928b4
[BEAM-1877] Use Iterables.isEmpty in GroupIntoBatches
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/cdbca15a
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/cdbca15a
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/cdbca15a
Branch: refs/heads/master
Commit: cdbca15afcd6a1e0d923ee32f33645aa4f1e39d9
Parents: 000378d
Author: Gergely Novak <gn...@hortonworks.com>
Authored: Tue Apr 25 12:53:26 2017 +0200
Committer: Luke Cwik <lc...@google.com>
Committed: Tue Apr 25 09:24:51 2017 -0700
----------------------------------------------------------------------
.../main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/beam/blob/cdbca15a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
----------------------------------------------------------------------
diff --git a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
index 2462b1c..b5547e3 100644
--- a/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
+++ b/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java
@@ -218,7 +218,7 @@ public class GroupIntoBatches<K, InputT>
CombiningState<Long, Long, Long> numElementsInBatch) {
Iterable<InputT> values = batch.read();
// when the timer fires, batch state might be empty
- if (Iterables.size(values) > 0) {
+ if (!Iterables.isEmpty(values)) {
c.output(KV.of(key.read(), values));
}
batch.clear();
[2/2] beam git commit: [BEAM-1877] Use Iterables.isEmpty in
GroupIntoBatches
Posted by lc...@apache.org.
[BEAM-1877] Use Iterables.isEmpty in GroupIntoBatches
This closes #2673
Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/6bca928b
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/6bca928b
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/6bca928b
Branch: refs/heads/master
Commit: 6bca928b490939df9c684e6b1ce3197e98f0630a
Parents: 000378d cdbca15
Author: Luke Cwik <lc...@google.com>
Authored: Tue Apr 25 09:25:14 2017 -0700
Committer: Luke Cwik <lc...@google.com>
Committed: Tue Apr 25 09:25:14 2017 -0700
----------------------------------------------------------------------
.../main/java/org/apache/beam/sdk/transforms/GroupIntoBatches.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------