You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by gg...@apache.org on 2021/08/14 13:11:59 UTC
[commons-pool] branch master updated: Use final,
remove trailing whitespace.
This is an automated email from the ASF dual-hosted git repository.
ggregory pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/commons-pool.git
The following commit(s) were added to refs/heads/master by this push:
new a97ca98 Use final, remove trailing whitespace.
a97ca98 is described below
commit a97ca986d6b94e68e3eff9a4bcf1cf0588f58bc9
Author: Gary Gregory <ga...@gmail.com>
AuthorDate: Sat Aug 14 09:11:57 2021 -0400
Use final, remove trailing whitespace.
---
.../java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java | 2 +-
.../java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java | 2 +-
src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java | 2 +-
src/test/java/org/apache/commons/pool2/impl/TestPoolImplUtils.java | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
index e69902e..dd5e164 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestAbandonedObjectPool.java
@@ -50,7 +50,7 @@ class PooledTestObject implements TrackedUse {
private static final Instant INSTANT_1 = Instant.ofEpochMilli(1);
private boolean active;
private boolean destroyed;
- private int hash;
+ private final int hash;
private boolean abandoned;
private boolean detached; // destroy-abandoned "detaches"
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
index 1fa9a91..13626dc 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericKeyedObjectPool.java
@@ -200,7 +200,7 @@ public class TestGenericKeyedObjectPool extends TestKeyedObjectPool {
private void doWait(final long latency) {
Waiter.sleepQuietly(latency);
}
-
+
@Override
public PooledObject<String> makeObject(final K key) throws Exception {
if (exceptionOnCreate) {
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
index 2daa884..8e38303 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestGenericObjectPool.java
@@ -1123,7 +1123,7 @@ public class TestGenericObjectPool extends TestBaseObjectPool {
/**
* On first borrow, first object fails validation, second object is OK.
* Subsequent borrows are OK. This was POOL-152.
- * @throws Exception
+ * @throws Exception
*/
@Test
@Timeout(value = 60000, unit = TimeUnit.MILLISECONDS)
diff --git a/src/test/java/org/apache/commons/pool2/impl/TestPoolImplUtils.java b/src/test/java/org/apache/commons/pool2/impl/TestPoolImplUtils.java
index 844996a..98b80e2 100644
--- a/src/test/java/org/apache/commons/pool2/impl/TestPoolImplUtils.java
+++ b/src/test/java/org/apache/commons/pool2/impl/TestPoolImplUtils.java
@@ -122,7 +122,7 @@ public class TestPoolImplUtils {
public void testToDuration() {
assertEquals(Duration.ZERO, PoolImplUtils.toDuration(0, TimeUnit.MILLISECONDS));
assertEquals(Duration.ofMillis(1), PoolImplUtils.toDuration(1, TimeUnit.MILLISECONDS));
- for (TimeUnit tu : TimeUnit.values()) {
+ for (final TimeUnit tu : TimeUnit.values()) {
// All TimeUnit should be handled.
assertEquals(Duration.ZERO, PoolImplUtils.toDuration(0, tu));
}