You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@logging.apache.org by "Robert Middleton (Jira)" <lo...@logging.apache.org> on 2021/12/26 21:21:00 UTC

[jira] [Updated] (LOGCXX-543) Some tests can fail when there is a "Q" in the pathname

     [ https://issues.apache.org/jira/browse/LOGCXX-543?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Robert Middleton updated LOGCXX-543:
------------------------------------
    Fix Version/s: 0.13.0

> Some tests can fail when there is a "Q" in the pathname
> -------------------------------------------------------
>
>                 Key: LOGCXX-543
>                 URL: https://issues.apache.org/jira/browse/LOGCXX-543
>             Project: Log4cxx
>          Issue Type: Bug
>          Components: Tests
>            Reporter: Tobias Frost
>            Priority: Minor
>             Fix For: 0.13.0
>
>         Attachments: 0004-Escape-sed-expression.patch
>
>
> During updating Debian's autopkgtest I came across the problem that sometimes e.g the patternlayouttest fails with something like this:
> {noformat}
> 51/57 Test #15: patternlayouttest ......................***Failed    0.17 sec
> LC_CTYPE: C.UTF-8
> patternlayouttest   :  sed: file output/patternlayout.sed line 1: unknown option to `s'
> Line 363: Compare::compare(FILTERED, LOG4CXX_FILE("witness/patternLayout.10")) was expected to be true, was false.
> sed: file output/patternlayout.sed line 1: unknown option to `s'{noformat}
> After some debugging into it, I figured out that "Q" is used as the seperator for sed and the patternlayouttest uses somewhere __FILE__ which ends up in an invalid sed expression. As autopkgtest copies the source tree to some mktemp-made directory, a "Q" can happen in the source path...
> The attached patch (I willl also make a PR) will make sure that any "Q"'s are escaped as "\Q" so that sed will not become unhappy.
>  
>  



--
This message was sent by Atlassian Jira
(v8.20.1#820001)