[GitHub] [beam] kamilwu commented on a change in pull request #12435: [BEAM-10616] Added Python Pardo load tests for streaming on Dataflow

[GitBox <gi...@apache.org>]

kamilwu commented on a change in pull request #12435:
URL: https://github.com/apache/beam/pull/12435#discussion_r476485871



##########
File path: sdks/python/apache_beam/testing/load_tests/pardo_test.py
##########
@@ -125,7 +125,9 @@ def process(self, element, state=state_param):
             state.add(1)
         yield element
 
-    if self.get_option_or_default('streaming', False):
+    if self.get_option_or_default(
+        'streaming',
+        False) and self.pipeline.get_option('runner') == "PortableRunner":

Review comment:
       Actually, `StatefulLoadGenerator` is no longer required to enable streaming for Flink (please do note I'm using `Flink` instead of `PortableRunner`. `PortableRunner` can run pipelines on any engine that supports portability, Flink included). SyntheticSource executes as SDF (Splittable DoFn). Since Python SDK supports streaming SDF (https://issues.apache.org/jira/browse/BEAM-3742), SyntheticSource should work on Flink.
   
   @mxm We'd love to hear your opinion. Should streaming ParDo tests for Flink still use `StatefulLoadGenerator`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org