You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2019/05/06 02:28:29 UTC

[GitHub] [bookkeeper] sijie commented on a change in pull request #2085: Fallback to use v3 protocol for some types of requests if they are not implemented in v2

sijie commented on a change in pull request #2085: Fallback to use v3 protocol for some types of requests if they are not implemented in v2
URL: https://github.com/apache/bookkeeper/pull/2085#discussion_r281051265
 
 

 ##########
 File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/proto/PerChannelBookieClientFactory.java
 ##########
 @@ -36,6 +36,6 @@
      * @return the client connected to address.
      * @throws SecurityException
      */
-    PerChannelBookieClient create(BookieSocketAddress address,
-            PerChannelBookieClientPool pcbcPool, SecurityHandlerFactory shFactory) throws SecurityException;
+    PerChannelBookieClient create(BookieSocketAddress address, PerChannelBookieClientPool pcbcPool,
 
 Review comment:
   I would suggest using `ProtocolVersion` in this method.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services