You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "oscerd (via GitHub)" <gi...@apache.org> on 2026/08/24 14:46:59 UTC

[PR] chore: assert the ckcMarshal route template still marshals [camel-kafka-connector]

oscerd opened a new pull request, #1818:
URL: https://github.com/apache/camel-kafka-connector/pull/1818

   Small follow-up to #1796 / #1795.
   
   ## Why
   
   #1796 fixed `ckcUnMarshal` calling `.marshal()` and added `testUnmarshalRouteActuallyUnmarshals` to
   guard that direction. Nothing asserts the same for `ckcMarshal`, so the symmetric mistake โ€” flipping
   the *other* template to `.unmarshal()` โ€” would pass CI unnoticed. The two templates sit next to each
   other and the original bug was a copy-paste between them, so it is worth pinning both ends.
   
   ## What
   
   Adds `testMarshalRouteActuallyMarshals`: a `SyslogMessage` sent through a route built with
   `camel.source.marshal` must come back encoded, not as a `SyslogMessage`.
   
   Confirmed it discriminates โ€” flipping `ckcMarshal` to `.unmarshal("{{marshal}}")` fails it:
   
   ```
   DataFormatTest.testMarshalRouteActuallyMarshals:200 ยป CamelExecution Exception occurred during
   execution on the exchange
   ```
   
   ## Verification
   
   - `core`: 121 tests pass.
   - `./mvnw -Psourcecheck -Dcheckstyle.failOnViolation=true checkstyle:checkstyle`: BUILD SUCCESS.
   - Full reactor build from the repository root (`./mvnw clean install -DskipTests`): BUILD SUCCESS.
   
   Test-only; no production code touched.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Re: [PR] chore: assert the ckcMarshal route template still marshals [camel-kafka-connector]

Posted by "oscerd (via GitHub)" <gi...@apache.org>.
oscerd merged PR #1818:
URL: https://github.com/apache/camel-kafka-connector/pull/1818


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org