You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Tim St Clair <ts...@redhat.com> on 2014/01/20 20:30:32 UTC
RBTools & post-review.
Greetings -
So I've updated to the lastest RBTools in Fedora 20 and it seems to have broken post-review. In fact, it looks as if post-review has been deprecated for some time now. Here is the change-log:
* Wed Jan 15 2014 Stephen Gallagher <sg...@redhat.com> 0.5.5-1
- New upstream release 0.5.5
- http://www.reviewboard.org/docs/releasenotes/rbtools/0.5.5/
- New upstream release 0.5.4
- http://www.reviewboard.org/docs/releasenotes/rbtools/0.5.4/
- Deprecation:
* post-review is deprecated (and has been for a while). It now shows a
deprecation warning in order to remind me to use rbt post.
- Bug Fixes:
* rbt patch:
* rbt patch no longer fails to commit on Git if there are untracked files.
* Fixed committing changes when the description has unicode characters.
* Fixed compatibility with Review Board 2.0 beta.
* rbt post:
* Fixed R1:R2 syntax for --revision-range for Git repositories.
* Fixed name-based lookups for repositories with Subversion.
* rbt setup-repo:
* Fixed error output when failing to write the .reviewboardrc file.
* post-review:
* Added --svn-show-copies-as-adds to post-review.
I may just downgrade and submit a ticket, but I thought I would email 1st.
--
Cheers,
Tim
Re: RBTools & post-review.
Posted by Tim St Clair <ts...@redhat.com>.
Ross -
I was able to use a rebuild of 0.5.5, notes are captured here : https://issues.apache.org/jira/browse/MESOS-931.
Cheers,
Tim
----- Original Message -----
> From: "Ross Allen" <ro...@mesosphere.io>
> To: dev@mesos.apache.org
> Sent: Monday, January 20, 2014 3:07:21 PM
> Subject: Re: RBTools & post-review.
>
> We ran into this same problem with version 0.5.3, which was released
> January 1 of this year. Downgrading to RBTools 0.5.2 made post-reviews.py
> work again.
>
> The diff between those patch releases is significant and included a rewrite
> of some of the Git implementation. I wasn't able to narrow the problem to
> specific code and so haven't yet opened an issue with the RB team.
>
> Do you want to open an issue with them?
>
> Am Montag, 20. Januar 2014 schrieb Tim St Clair :
>
> > Greetings -
> >
> > So I've updated to the lastest RBTools in Fedora 20 and it seems to have
> > broken post-review. In fact, it looks as if post-review has been
> > deprecated for some time now. Here is the change-log:
> >
> > * Wed Jan 15 2014 Stephen Gallagher <sgallagh@redhat.com <javascript:;>>
> > 0.5.5-1
> > - New upstream release 0.5.5
> > - http://www.reviewboard.org/docs/releasenotes/rbtools/0.5.5/
> > - New upstream release 0.5.4
> > - http://www.reviewboard.org/docs/releasenotes/rbtools/0.5.4/
> > - Deprecation:
> > * post-review is deprecated (and has been for a while). It now shows a
> > deprecation warning in order to remind me to use rbt post.
> > - Bug Fixes:
> > * rbt patch:
> > * rbt patch no longer fails to commit on Git if there are untracked
> > files.
> > * Fixed committing changes when the description has unicode characters.
> > * Fixed compatibility with Review Board 2.0 beta.
> > * rbt post:
> > * Fixed R1:R2 syntax for --revision-range for Git repositories.
> > * Fixed name-based lookups for repositories with Subversion.
> > * rbt setup-repo:
> > * Fixed error output when failing to write the .reviewboardrc file.
> > * post-review:
> > * Added --svn-show-copies-as-adds to post-review.
> >
> >
> > I may just downgrade and submit a ticket, but I thought I would email 1st.
> >
> >
> > --
> > Cheers,
> > Tim
> >
>
>
> --
> Ross Allen
> ross@mesosphere.io
>
--
Cheers,
Tim
Re: RBTools & post-review.
Posted by Ross Allen <ro...@mesosphere.io>.
We ran into this same problem with version 0.5.3, which was released
January 1 of this year. Downgrading to RBTools 0.5.2 made post-reviews.py
work again.
The diff between those patch releases is significant and included a rewrite
of some of the Git implementation. I wasn't able to narrow the problem to
specific code and so haven't yet opened an issue with the RB team.
Do you want to open an issue with them?
Am Montag, 20. Januar 2014 schrieb Tim St Clair :
> Greetings -
>
> So I've updated to the lastest RBTools in Fedora 20 and it seems to have
> broken post-review. In fact, it looks as if post-review has been
> deprecated for some time now. Here is the change-log:
>
> * Wed Jan 15 2014 Stephen Gallagher <sgallagh@redhat.com <javascript:;>>
> 0.5.5-1
> - New upstream release 0.5.5
> - http://www.reviewboard.org/docs/releasenotes/rbtools/0.5.5/
> - New upstream release 0.5.4
> - http://www.reviewboard.org/docs/releasenotes/rbtools/0.5.4/
> - Deprecation:
> * post-review is deprecated (and has been for a while). It now shows a
> deprecation warning in order to remind me to use rbt post.
> - Bug Fixes:
> * rbt patch:
> * rbt patch no longer fails to commit on Git if there are untracked
> files.
> * Fixed committing changes when the description has unicode characters.
> * Fixed compatibility with Review Board 2.0 beta.
> * rbt post:
> * Fixed R1:R2 syntax for --revision-range for Git repositories.
> * Fixed name-based lookups for repositories with Subversion.
> * rbt setup-repo:
> * Fixed error output when failing to write the .reviewboardrc file.
> * post-review:
> * Added --svn-show-copies-as-adds to post-review.
>
>
> I may just downgrade and submit a ticket, but I thought I would email 1st.
>
>
> --
> Cheers,
> Tim
>
--
Ross Allen
ross@mesosphere.io