thrift command missing on Jenkins?

[Alex Van Boxel <al...@vanboxel.be>]

I think the Thrift PR broke master. I rebased (and see other new PR's) fail
with:

* What went wrong:*15:30:40* Execution failed for task
':sdks:java:io:thrift:compileThrift'.*15:30:40* > A problem occurred
starting process 'command 'thrift''


 _/
_/ Alex Van Boxel

Re: thrift command missing on Jenkins?

[Ismaël Mejía <ie...@gmail.com>]

For info the fix was merged into master, kudos to Christopher Larsen for
the quick fix.

On Tue, Feb 18, 2020 at 9:43 PM Ismaël Mejía <ie...@gmail.com> wrote:

> For info we decided to took the approach 2 Chris will open a PR to do so
> and we will get it fixed ASAP.
> Thanks Alex for reporting and sorry for the inconvenience.
>
> On Tue, Feb 18, 2020 at 9:36 PM Ismaël Mejía <ie...@gmail.com> wrote:
>
>> Mmm that one could be on me, I tested it locally and merged the PR today,
>> it worked flawlessly in my machine, but now I realize that I have thrift
>> installed locally because it is a requirement when you hack on parquet-mr
>> code.
>>
>> So two workarounds possible:
>>
>> 1. We install Thrift 0.12 in all the Jenkins workers + update
>> instructions so everyone does.
>> 2. We disable the Thrift compiler step and use a generated class and
>> upgrade that every time.
>>
>> I am away from my work computer so can someone help me please to unblock
>> this otherwise I will take care tomorrow.
>>
>>
>>
>> On Tue, Feb 18, 2020 at 7:43 PM Alex Van Boxel <al...@vanboxel.be> wrote:
>>
>>> I think the Thrift PR broke master. I rebased (and see other new PR's)
>>> fail with:
>>>
>>> * What went wrong:*15:30:40* Execution failed for task ':sdks:java:io:thrift:compileThrift'.*15:30:40* > A problem occurred starting process 'command 'thrift''
>>>
>>>
>>>  _/
>>> _/ Alex Van Boxel
>>>
>>

Re: thrift command missing on Jenkins?

[Ismaël Mejía <ie...@gmail.com>]

For info we decided to took the approach 2 Chris will open a PR to do so
and we will get it fixed ASAP.
Thanks Alex for reporting and sorry for the inconvenience.

On Tue, Feb 18, 2020 at 9:36 PM Ismaël Mejía <ie...@gmail.com> wrote:

> Mmm that one could be on me, I tested it locally and merged the PR today,
> it worked flawlessly in my machine, but now I realize that I have thrift
> installed locally because it is a requirement when you hack on parquet-mr
> code.
>
> So two workarounds possible:
>
> 1. We install Thrift 0.12 in all the Jenkins workers + update instructions
> so everyone does.
> 2. We disable the Thrift compiler step and use a generated class and
> upgrade that every time.
>
> I am away from my work computer so can someone help me please to unblock
> this otherwise I will take care tomorrow.
>
>
>
> On Tue, Feb 18, 2020 at 7:43 PM Alex Van Boxel <al...@vanboxel.be> wrote:
>
>> I think the Thrift PR broke master. I rebased (and see other new PR's)
>> fail with:
>>
>> * What went wrong:*15:30:40* Execution failed for task ':sdks:java:io:thrift:compileThrift'.*15:30:40* > A problem occurred starting process 'command 'thrift''
>>
>>
>>  _/
>> _/ Alex Van Boxel
>>
>

Re: thrift command missing on Jenkins?

[Ismaël Mejía <ie...@gmail.com>]

Mmm that one could be on me, I tested it locally and merged the PR today,
it worked flawlessly in my machine, but now I realize that I have thrift
installed locally because it is a requirement when you hack on parquet-mr
code.

So two workarounds possible:

1. We install Thrift 0.12 in all the Jenkins workers + update instructions
so everyone does.
2. We disable the Thrift compiler step and use a generated class and
upgrade that every time.

I am away from my work computer so can someone help me please to unblock
this otherwise I will take care tomorrow.



On Tue, Feb 18, 2020 at 7:43 PM Alex Van Boxel <al...@vanboxel.be> wrote:

> I think the Thrift PR broke master. I rebased (and see other new PR's)
> fail with:
>
> * What went wrong:*15:30:40* Execution failed for task ':sdks:java:io:thrift:compileThrift'.*15:30:40* > A problem occurred starting process 'command 'thrift''
>
>
>  _/
> _/ Alex Van Boxel
>