You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by srowen <gi...@git.apache.org> on 2016/07/15 11:24:40 UTC
[GitHub] spark pull request #14221: [SPARK-3359] [DOCS] More changes to resolve javad...
GitHub user srowen opened a pull request:
https://github.com/apache/spark/pull/14221
[SPARK-3359] [DOCS] More changes to resolve javadoc 8 errors that will help unidoc/genjavadoc compatibility
## What changes were proposed in this pull request?
These are yet more changes that resolve problems with unidoc/genjavadoc and Java 8. It does not fully resolve the problem, but gets rid of as many errors as we can from this end.
## How was this patch tested?
Jenkins build of docs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/srowen/spark SPARK-3359.3
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14221.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14221
----
commit ea8884562f696da979a353bdb49a008fdd8049bd
Author: Sean Owen <so...@cloudera.com>
Date: 2016-07-15T11:23:01Z
More changes to resolve javadoc 8 errors that will help unidoc to work with Java 8; does not fully resolve the issue
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14221: [SPARK-3359] [DOCS] More changes to resolve javad...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14221#discussion_r70957858
--- Diff: graphx/src/main/scala/org/apache/spark/graphx/util/GraphGenerators.scala ---
@@ -119,7 +119,7 @@ object GraphGenerators extends Logging {
* A random graph generator using the R-MAT model, proposed in
* "R-MAT: A Recursive Model for Graph Mining" by Chakrabarti et al.
*
- * See [[http://www.cs.cmu.edu/~christos/PUBLICATIONS/siam04.pdf]].
+ * See http://www.cs.cmu.edu/~christos/PUBLICATIONS/siam04.pdf.
--- End diff --
Was valid scaladoc but doesn't convert to valid javadoc; it's a genjavadoc limitation
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14221: [SPARK-3359] [DOCS] More changes to resolve javadoc 8 er...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14221
**[Test build #62374 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62374/consoleFull)** for PR 14221 at commit [`ea88845`](https://github.com/apache/spark/commit/ea8884562f696da979a353bdb49a008fdd8049bd).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14221: [SPARK-3359] [DOCS] More changes to resolve javadoc 8 er...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14221
Merged build finished. Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14221: [SPARK-3359] [DOCS] More changes to resolve javad...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/spark/pull/14221
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14221: [SPARK-3359] [DOCS] More changes to resolve javadoc 8 er...
Posted by rxin <gi...@git.apache.org>.
Github user rxin commented on the issue:
https://github.com/apache/spark/pull/14221
Merging in master/2.0.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark pull request #14221: [SPARK-3359] [DOCS] More changes to resolve javad...
Posted by srowen <gi...@git.apache.org>.
Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14221#discussion_r70957938
--- Diff: mllib/src/main/scala/org/apache/spark/ml/Pipeline.scala ---
@@ -212,7 +212,7 @@ object Pipeline extends MLReadable[Pipeline] {
}
}
- /** Methods for [[MLReader]] and [[MLWriter]] shared between [[Pipeline]] and [[PipelineModel]] */
+ /** Methods for `MLReader` and `MLWriter` shared between [[Pipeline]] and [[PipelineModel]] */
--- End diff --
Several of these instances are because for whatever reason visibility is wrong in the generated javadoc and so it fails. It seemed more worth it to zap the error than retain these links.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14221: [SPARK-3359] [DOCS] More changes to resolve javadoc 8 er...
Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:
https://github.com/apache/spark/pull/14221
**[Test build #62374 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/62374/consoleFull)** for PR 14221 at commit [`ea88845`](https://github.com/apache/spark/commit/ea8884562f696da979a353bdb49a008fdd8049bd).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] spark issue #14221: [SPARK-3359] [DOCS] More changes to resolve javadoc 8 er...
Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:
https://github.com/apache/spark/pull/14221
Test PASSed.
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/62374/
Test PASSed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org