You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zeppelin.apache.org by 1ambda <gi...@git.apache.org> on 2017/04/04 06:17:57 UTC

[GitHub] zeppelin pull request #2218: [ZEPPELIN-2348] Line chart setting is not rende...

GitHub user 1ambda opened a pull request:

    https://github.com/apache/zeppelin/pull/2218

    [ZEPPELIN-2348] Line chart setting is not rendered (master)

    ### What is this PR for?
    
    Line chart setting is not rendered.
    
    ### What type of PR is it?
    [Bug Fix | Improvement | Feature | Documentation | Hot Fix | Refactoring]
    
    ### Todos
    
    None.
    
    ### What is the Jira issue?
    
    [ZEPPELIN-2348](https://issues.apache.org/jira/browse/ZEPPELIN-2348)
    
    ### How should this be tested?
    
    1. Open the default line chart's setting
    2. Check checkboxes for options.
    
    ### Screenshots (if appropriate)
    
    ![image](https://cloud.githubusercontent.com/assets/4968473/24643544/ad22b336-1949-11e7-95c4-5a5ba17f1d1b.png)
    
    ### Questions:
    * Does the licenses files need update? - NO
    * Is there breaking changes for older versions? - NO
    * Does this needs documentation? - NO


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/1ambda/zeppelin ZEPPELIN-2348/line-chart-setting-msater

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2218.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2218
    
----
commit 0f3ea04cb299d4080317b5bef1168d81f091ed07
Author: 1ambda <1a...@gmail.com>
Date:   2017-04-04T05:00:18Z

    fix: Tr, Vis setting

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2218: [ZEPPELIN-2348] Line chart setting is not rendered (ma...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2218
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2218: [ZEPPELIN-2348] Line chart setting is not rendered (ma...

Posted by Leemoonsoo <gi...@git.apache.org>.
Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2218
  
    While this fixes broken feature, i'm merging it to master as a hotfix. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2218: [ZEPPELIN-2348] Line chart setting is not rende...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2218


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---