[GitHub] [flink] godfreyhe commented on a change in pull request #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #8878: [FLINK-12971][table-planner-blink] Remove the constraint that lookup join needs a primary key or index key
URL: https://github.com/apache/flink/pull/8878#discussion_r297461744
 
 

 ##########
 File path: flink-table/flink-table-planner-blink/src/main/scala/org/apache/flink/table/plan/nodes/common/CommonLookupJoin.scala
 ##########
 @@ -85,19 +84,14 @@ abstract class CommonLookupJoin(
   with FlinkRelNode {
 
   val joinKeyPairs: Array[IntPair] = getTemporalTableJoinKeyPairs(joinInfo, calcOnTemporalTable)
-  val indexKeys: Array[TableIndex] = getTableIndexes(tableSource)
   // all potential index keys, mapping from field index in table source to LookupKey
   val allLookupKeys: Map[Int, LookupKey] = analyzeLookupKeys(
     cluster.getRexBuilder,
     joinKeyPairs,
-    indexKeys,
     tableSource.getTableSchema,
     calcOnTemporalTable)
   // the matched best lookup fields which is in defined order, maybe empty
-  val matchedLookupFields: Option[Array[Int]] = findMatchedIndex(
-    indexKeys,
-    tableSource.getTableSchema,
-    allLookupKeys)
+  val matchedLookupFields: Option[Array[Int]] = findMatchedIndex(allLookupKeys)
 
 Review comment:
   matchedLookupFields could be removed

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services