You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@samza.apache.org by GitBox <gi...@apache.org> on 2020/08/05 18:33:08 UTC
[GitHub] [samza] sborya commented on a change in pull request #1408: SAMZA-2574: improve flexibility of SystemFactory interface
sborya commented on a change in pull request #1408:
URL: https://github.com/apache/samza/pull/1408#discussion_r465922429
##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
SystemProducer getProducer(String systemName, Config config, MetricsRegistry registry);
SystemAdmin getAdmin(String systemName, Config config);
+
+ default SystemConsumer getConsumer(String systemName, Config config, MetricsRegistry registry, String callerClass) {
Review comment:
please rename callClass to 'consumerIdPrefix'
##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
SystemProducer getProducer(String systemName, Config config, MetricsRegistry registry);
SystemAdmin getAdmin(String systemName, Config config);
+
+ default SystemConsumer getConsumer(String systemName, Config config, MetricsRegistry registry, String callerClass) {
+ return getConsumer(systemName, config, registry);
+ }
+
+ default SystemProducer getProducer(String systemName, Config config, MetricsRegistry registry, String callerClass) {
Review comment:
please rename callClass to 'producerIdPrefix'
##########
File path: samza-api/src/main/java/org/apache/samza/system/SystemFactory.java
##########
@@ -32,4 +32,16 @@
SystemProducer getProducer(String systemName, Config config, MetricsRegistry registry);
SystemAdmin getAdmin(String systemName, Config config);
+
+ default SystemConsumer getConsumer(String systemName, Config config, MetricsRegistry registry, String callerClass) {
+ return getConsumer(systemName, config, registry);
+ }
+
+ default SystemProducer getProducer(String systemName, Config config, MetricsRegistry registry, String callerClass) {
+ return getProducer(systemName, config, registry);
+ }
+
+ default SystemAdmin getAdmin(String systemName, Config config, String callerClass) {
Review comment:
please rename callClass to 'adminIdPrefix'
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org