[GitHub] spark pull request #17361: [SPARK-20030][SS] Event-time-based timeout for Ma...

[marmbrus <gi...@git.apache.org>]

Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/17361#discussion_r107304133
  
    --- Diff: sql/catalyst/src/main/java/org/apache/spark/sql/streaming/KeyedStateTimeout.java ---
    @@ -34,9 +32,20 @@
     @InterfaceStability.Evolving
     public class KeyedStateTimeout {
     
    -  /** Timeout based on processing time.  */
    +  /**
    +   * Timeout based on processing time. The duration of timeout can be set for each group in
    +   * `map/flatMapGroupsWithState` by calling `KeyedState.setTimeoutDuration()`.
    +   */
       public static KeyedStateTimeout ProcessingTimeTimeout() { return ProcessingTimeTimeout$.MODULE$; }
    --- End diff --
    
    Nit: I'd consider removing the `Timeout` here and as its kind of redundant.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org