You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/07 03:40:12 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12695: [Bug] [dolphinscheduler-api] in the task define list, when edit task, should show pre node list

caishunfeng commented on code in PR #12695:
URL: https://github.com/apache/dolphinscheduler/pull/12695#discussion_r1014978419


##########
dolphinscheduler-dao/src/main/java/org/apache/dolphinscheduler/dao/entity/TaskDefinition.java:
##########
@@ -218,6 +218,12 @@ public class TaskDefinition {
      */
     private TaskExecuteType taskExecuteType;
 
+    /**
+     * process task related list
+     */
+    @TableField(exist = false)
+    private List<ProcessTaskRelation> processTaskRelationList;

Review Comment:
   I think it's better to use `TaskDefinitionVo` and don't add these fileds in dao entity.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org